Looks good to me.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Feb 9 2022
Feb 9 2022
anlambert requested review of D7129: utils: Fix hidden path processing in parse_external_definition.
Feb 8 2022
Feb 8 2022
anlambert requested review of D7127: replay: Prevent external path removal when defined on multiple dirs.
Looks like release objects cannot be currently cooked, I guess you have another diff coming to add such support ?
Looking at puppet configuration, my guess is that the sentry_dsn is not set for the vault cookers.
Cypress tests can be simplified before landing this.
anlambert added inline comments to D7099: replay: Use remote repository base URL to export external located in it.
anlambert updated the diff for D7099: replay: Use remote repository base URL to export external located in it.
Add non regression test
anlambert updated the diff for D7099: replay: Use remote repository base URL to export external located in it.
Update: Rebase and improve debug logging
anlambert added inline comments to D7099: replay: Use remote repository base URL to export external located in it.
anlambert committed rDLDSVNd929eebd3924: replay: Check relative / recursive externals only when closing root dir (authored by anlambert).
replay: Check relative / recursive externals only when closing root dir
Feb 7 2022
Feb 7 2022
anlambert committed rDWAPPSaeb6d7cdbcad: tests: Fix flaky test introduced in e72b1e7a9d18 (authored by anlambert).
tests: Fix flaky test introduced in e72b1e7a9d18
anlambert requested changes to D7096: mailmaps: Return a proper error in case of duplicate from_email.
I think you miss my inline comment so I put this in request changes.
Looks good to me.
anlambert committed rDWAPPSca8e529f2db4: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
anlambert committed rDWAPPS84035408f015: templates/origin-visits: Prefer to show all visits by default (authored by anlambert).
templates/origin-visits: Prefer to show all visits by default
Some more details about why the tests are failing since the release of pytest 7.0.0,
this is due to two external pytest modules we are using that are importing private
pytest modules that were removed:
- pytest-postgresql < 4.0.0
- pytest-redis
anlambert requested review of D7107: replay: Check relative / recursive externals only when closing root dir.
anlambert updated the diff for D7099: replay: Use remote repository base URL to export external located in it.
Update: Add trailing slash when testing URL prefix.
anlambert committed rDWCLI133a4ac7d68a: docs: Remove reference to no longer existing swh command (authored by anlambert).
docs: Remove reference to no longer existing swh command
anlambert added inline comments to D7099: replay: Use remote repository base URL to export external located in it.
anlambert requested review of D7099: replay: Use remote repository base URL to export external located in it.
anlambert added inline comments to D7096: mailmaps: Return a proper error in case of duplicate from_email.
This page should contain a link to the different guides and to the guided tour.
Also, when the guided tour is published, would this page disappear?
by clicking on help you enter the guided tour but you might want access to specific guides and FAQ.
anlambert added inline comments to D7078: Find latest origin visit status by date instead of visits filtering.
Looks good to me.
Feb 4 2022
Feb 4 2022
anlambert committed rDLDSVN20c1445fb11e: replay: Handle externals targeting the same path (authored by anlambert).
replay: Handle externals targeting the same path
anlambert committed rDLDSVNcb1b59ca3401: replay: Prevent erroneous removal of versioned path (authored by anlambert).
replay: Prevent erroneous removal of versioned path
anlambert committed rDLDSVN651bb4e0b5c4: replay: Improve signature of DirEditor.open_file method (authored by anlambert).
replay: Improve signature of DirEditor.open_file method
anlambert committed rDLDSVNd5bdea55bc52: replay: Move external processing in a dedicated method (authored by anlambert).
replay: Move external processing in a dedicated method
anlambert committed rDLDSVN369fbea00ea5: svn: Add debug log before executing checkout or export operation (authored by anlambert).
svn: Add debug log before executing checkout or export operation
anlambert committed rDLDSVN8bde0663cb4a: requirements-test: Pin pytest to < 7.0.0 (authored by anlambert).
requirements-test: Pin pytest to < 7.0.0
Fix typo.
Add docstring for externals member of DirState.
anlambert added a comment to rDSTO0f9f54b72e51: revision_walker: Add support for ignore_displayname..
I think you forgot to pass the ignore_displayname parameter to storage.revision_log line 166, no ?
anlambert added inline comments to D7078: Find latest origin visit status by date instead of visits filtering.
anlambert added inline comments to D7078: Find latest origin visit status by date instead of visits filtering.
anlambert committed rDWAPPS4ed4512e7bdf: templates/show-swhid: Add link to HOWTO reference your code page (authored by anlambert).
templates/show-swhid: Add link to HOWTO reference your code page
anlambert requested review of D7089: templates/show-swhid: Add link to HOWTO reference your code page.
I think the proper place for that link would be the Permalinks tab.
Add typing
I forgot to add typing, will update.
anlambert committed rDWAPPS3f465b3025f1: requirements-test: Pin pytest to < 7.0.0 (authored by anlambert).
requirements-test: Pin pytest to < 7.0.0
anlambert requested review of D7085: svn: Add debug log before executing checkout or export operation.
anlambert committed rDLDSVN09e83fd94cc0: svn: Optimize propget performance after checkout (authored by anlambert).
svn: Optimize propget performance after checkout
anlambert requested changes to D7078: Find latest origin visit status by date instead of visits filtering.
Looks good, thanks !
anlambert committed rDWAPPSe72b1e7a9d18: tests: Remove use of mocks in common/test_origin_visits (authored by anlambert).
tests: Remove use of mocks in common/test_origin_visits
Feb 3 2022
Feb 3 2022
Indeed this origin visits retrieving process is quite time consuming for origins with numerous visits,
especially when getting all visits again while most of them are already in cache (sighs, my bad for this).
anlambert committed rDWAPPSf2cf669b55de: auth: Add UserMailmap model and edition endpoints (authored by anlambert).
auth: Add UserMailmap model and edition endpoints