Differential D7107

replay: Check relative / recursive externals only when closing root dir
ClosedPublic
Actions

Authored by anlambert on Feb 7 2022, 4:52 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T611: support for external definitions in the svn/subversion loader

Commits

rDLDSVNd929eebd3924: replay: Check relative / recursive externals only when closing root dir

Summary

These operations need only to be performed once at the end of a revision
replay when closing the root directory.

Previously it was performed each time a sub-directory was closed which
was significantly slowing down the loading process.

Related to T611

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Feb 7 2022, 4:52 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 7 2022, 4:52 PM

Build is green

Patch application report for D7107 (id=25767)

Rebasing onto 20c1445fb1...

Current branch diff-target is up to date.

Changes applied before test

commit d929eebd392464e66db741793b47ab4f13e3b192
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Feb 7 16:48:51 2022 +0100

    replay: Check relative / recursive externals only when closing root dir
    
    These operations need only to be performed once at the end of a revision
    replay when closing the root directory.
    
    Previously it was performed each time a sub-directory was closed which
    was significantly slowing down the loading process.
    
    Related to T611

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/288/ for more details.

Harbormaster completed remote builds in B26610: Diff 25767.Feb 7 2022, 4:54 PM

anlambert requested review of this revision.Feb 7 2022, 4:54 PM

vlorentz accepted this revision.Feb 7 2022, 11:14 PM

This revision is now accepted and ready to land.Feb 7 2022, 11:14 PM

Closed by commit rDLDSVNd929eebd3924: replay: Check relative / recursive externals only when closing root dir (authored by anlambert). · Explain WhyFeb 8 2022, 11:08 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVNd929eebd3924: replay: Check relative / recursive externals only when closing root dir.