Page MenuHomeSoftware Heritage

templates/origin-visits: Prefer to show all visits by default
ClosedPublic

Authored by anlambert on Feb 7 2022, 3:00 PM.

Details

Summary

There is a lot of origins without any full visit in the archive so in
that case the origin visits page looks empty when reaching it as the
default is to display full visits with different snapshots.

See https://archive.softwareheritage.org/browse/origin/visits/?origin_url=https://guix.gnu.org/sources.json
for instance.

So prefer to display all visits by default and disable the full visits
switch radio buttons when there is no such visits.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D7097 (id=25749)

Rebasing onto d4ca7bede2...

Current branch diff-target is up to date.
Changes applied before test
commit 84035408f01503bf46067d14c60bc898e9f6402d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Feb 7 14:58:32 2022 +0100

    templates/origin-visits: Prefer to show all visits by default
    
    There is a lot of origins without any full visit in the archive so in
    that case the origin visits page looks empty when reaching it as the
    default is to display full visits with different snapshots.
    
    So prefer to display all visits by default and disable the full visits
    switch radio buttons when there is no such visits.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1344/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1344/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 7 2022, 3:16 PM
Harbormaster failed remote builds in B26578: Diff 25749!

Build is green

Patch application report for D7097 (id=25749)

Rebasing onto d4ca7bede2...

Current branch diff-target is up to date.
Changes applied before test
commit 84035408f01503bf46067d14c60bc898e9f6402d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Feb 7 14:58:32 2022 +0100

    templates/origin-visits: Prefer to show all visits by default
    
    There is a lot of origins without any full visit in the archive so in
    that case the origin visits page looks empty when reaching it as the
    default is to display full visits with different snapshots.
    
    So prefer to display all visits by default and disable the full visits
    switch radio buttons when there is no such visits.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1346/ for more details.

This revision is now accepted and ready to land.Feb 7 2022, 4:23 PM