Page MenuHomeSoftware Heritage

mailmaps: Make error handling more robust when 'from_email' is missing/empty.
ClosedPublic

Authored by vlorentz on Feb 7 2022, 3:02 PM.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7098 (id=25750)

Could not rebase; Attempt merge onto d4ca7bede2...

Updating d4ca7bed..74157d48
Fast-forward
 swh/web/auth/mailmap.py            | 31 ++++++++++++++++++++++------
 swh/web/tests/auth/test_mailmap.py | 41 +++++++++++++++++++++++++++++++++++---
 2 files changed, 63 insertions(+), 9 deletions(-)
Changes applied before test
commit 74157d48cd2c05951cf6e8f8910fb215791c63d9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 7 15:02:15 2022 +0100

    mailmaps: Make error handling more robust when 'from_email' is missing/empty.

commit ca4020e97dcf6ee4fc987400646fad6ccce87824
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 7 14:50:58 2022 +0100

    mailmaps: Return a proper error in case of duplicate from_email
    
    Instead of a generic 500.

commit 98bdf12aea75bdcc2e3e96b49515112987daa164
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 7 14:49:54 2022 +0100

    mailmaps: Add an endpoint to fetch the list
    
    This will be useful for debugging and checking records are indeed
    configured.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1345/ for more details.

This revision is now accepted and ready to land.Feb 7 2022, 3:33 PM
This revision was landed with ongoing or failed builds.Feb 7 2022, 7:10 PM
This revision was automatically updated to reflect the committed changes.