rebase

fix docstring rst syntax

apply vlorentz' comments

rebase

Use a hardwritten list of accepted objects

used another approach, see D6571

apply vlorentz' comments/suggestions

fix test_cli

rebase and a few fixes

"fix" mypy

In D6570#171059, @douardda wrote:

In D6570#170758, @vlorentz wrote:

You checked on the whole journal, right?

not yet. The shouldn't be any left, but... I'll check as soon as I have credentials for the production kafka cluster.

Bump the dependency on swh-journal to 0.9

In D6570#170941, @olasd wrote:

While we're here, could you check whether the other fixers are really still needed too?

In D6570#170758, @vlorentz wrote:

You checked on the whole journal, right?

^x^s...

typo

Overall it looks very good to me. There is room for improvement, for sure, but let's put this to work and see how it performs.

Document a bit more the value_deserializer and add a test for it

asking for review even if tests are expected to fail because it depends on D6565 (in swh-journal)

In D6564#170522, @ardumont wrote:

why if i may ask?

A bit sad, but hey, thanks!

Let's consider this is done since 2 of 3 bullets have been canceled (for now)

rebase

and fix the LOGGER.error usage

remove hardcoded log levels

Use ReadOnlyObjStorage and NonIterableObjStorage instead of NotImplementedError

document the build_objstorage() test helper function

remove useless statement

remove mistakenly commited mypy.ini file

rebase

remove a (comment) garbage line

rebase

slight simplification as suggested by vlorentz

respawn jenkins

respawn jenkins

rebase

split the diff in 2

B3 I am not convinced a "synthetic" flag on the Snapshot branch makes sense, or at least I find this name confusing, especially considering we already have a synthetic flag on Revision: it's not synthetic in the sense of it's not object crafted by SWH, it comes from the origin.

Ok I think what puzzle me in this description is the fact the 2 first bullets of the "git loader adaptations" are actually only one point: at the end of a successful loading, store a mapping in the extid table.

forgotten print statement...

In T3627#71819, @vlorentz wrote:

An alternative to annotating synthetic refs: add a "type" or "forge_type" attribute to snapshots.

What's the difference in deployed dependencies versions (staging vs. prod)?

For ENEA I'd llike to test different scenarios for the source objstorage: