Page MenuHomeSoftware Heritage
Differential D6570

Remove now useless revision date checker in fixer
ClosedPublic
Actions

Authored by douardda on Oct 27 2021, 6:22 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDSTO04bd15a0bca8: Refactor fixer.fix_objects() to extract the inner object_fixers dict
rDSTOd655c8581d3c: Remove now useless fixers
Summary

Depends on D6569.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Oct 27 2021, 6:22 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 27 2021, 6:22 PM
swh-public-ci added a comment.Oct 27 2021, 6:23 PM

Build has FAILED

Patch application report for D6570 (id=23872)

Could not rebase; Attempt merge onto 49a932c989...

Updating 49a932c9..b44a1eea
Fast-forward
 swh/storage/cli.py   | 14 ++++++++++-
 swh/storage/fixer.py | 68 +++-------------------------------------------------
 2 files changed, 16 insertions(+), 66 deletions(-)
Changes applied before test
commit b44a1eea08f081cef2d5ddb3663403b1f8cd4ed8
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Oct 27 16:55:03 2021 +0200

    Remove now useless revision date checker in fixer

commit 74dbb2b0b148750de272f2f1a523c72b6b2e1365
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 26 16:38:26 2021 +0200

    Add a --type option to 'swh storage replay'
    
    allows to choose replayed object types from the cli.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1464/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1464/console

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 27 2021, 6:23 PM
Harbormaster failed remote builds in B24754: Diff 23872!
douardda added a child revision: D6571: Add support for a redis-based reporting for invalid mirrorred objects.Oct 27 2021, 6:24 PM
douardda updated this revision to Diff 23880.Oct 28 2021, 10:15 AM
douardda retitled this revision from Remove now useless revision date checker in fixer Depends on D6569. to Remove now useless revision date checker in fixer.
douardda edited the summary of this revision. (Show Details)
douardda added a parent revision: D6569: Add a --type option to 'swh storage replay'.

rebase

swh-public-ci added a comment.Oct 28 2021, 10:23 AM

Build is green

Patch application report for D6570 (id=23880)

Could not rebase; Attempt merge onto 49a932c989...

Updating 49a932c9..693acf27
Fast-forward
 swh/storage/cli.py   | 14 ++++++++++-
 swh/storage/fixer.py | 68 +++-------------------------------------------------
 2 files changed, 16 insertions(+), 66 deletions(-)
Changes applied before test
commit 693acf2760117d1a5f04a1143721662c903d1276
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Oct 27 16:55:03 2021 +0200

    Remove now useless revision date checker in fixer

commit 04ba5910d53c8e9eb55a4bc2396840f9a47a5ac5
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 26 16:38:26 2021 +0200

    Add a --type option to 'swh storage replay'
    
    allows to choose replayed object types from the cli.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1468/ for more details.

Harbormaster completed remote builds in B24761: Diff 23880.Oct 28 2021, 10:23 AM
douardda requested review of this revision.Oct 28 2021, 10:23 AM
ardumont added a subscriber: ardumont.Oct 28 2021, 11:00 AM

A small description to mention why it's now useless would be great.

vlorentz added a subscriber: vlorentz.Oct 28 2021, 12:07 PM

You checked on the whole journal, right?

olasd added a subscriber: olasd.Oct 28 2021, 2:51 PM

While we're here, could you check whether the other fixers are really still needed too?

douardda added a comment.Oct 28 2021, 4:17 PM
In D6570#170758, @vlorentz wrote:

You checked on the whole journal, right?

not yet. The shouldn't be any left, but... I'll check as soon as I have credentials for the production kafka cluster.

douardda added a comment.Oct 28 2021, 4:18 PM
In D6570#170941, @olasd wrote:

While we're here, could you check whether the other fixers are really still needed too?

good thinking, will do

douardda added a comment.Oct 29 2021, 10:12 AM
In D6570#171059, @douardda wrote:
In D6570#170758, @vlorentz wrote:

You checked on the whole journal, right?

not yet. The shouldn't be any left, but... I'll check as soon as I have credentials for the production kafka cluster.

SO yes I did check and found no revision concerned by either _check_revision_date, _fix_revision_pypi_empty_string nor _fix_revision_transplant_source

vlorentz accepted this revision.Nov 4 2021, 10:44 AM
This revision is now accepted and ready to land.Nov 4 2021, 10:44 AM
douardda updated this revision to Diff 24037.Nov 8 2021, 3:27 PM

rebase

swh-public-ci added a comment.Nov 8 2021, 3:35 PM

Build is green

Patch application report for D6570 (id=24037)

Could not rebase; Attempt merge onto a5bfe5b514...

Merge made by the 'recursive' strategy.
 swh/storage/cli.py            |  31 ++++-
 swh/storage/fixer.py          | 290 ++----------------------------------------
 swh/storage/tests/test_cli.py |  14 ++
 3 files changed, 56 insertions(+), 279 deletions(-)
Changes applied before test
commit 110788b3d58e7461cb06b73544d2c57f47177699
Merge: a5bfe5b5 17282b47
Author: Jenkins user <jenkins@localhost>
Date:   Mon Nov 8 14:27:18 2021 +0000

    Merge branch 'diff-target' into HEAD

commit 17282b47287a8258f3dca66f54a865485548ccc4
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Oct 27 16:56:53 2021 +0200

    Refactor fixer.fix_objects() to extract the inner object_fixers dict
    
    allowing to use this dict independently of the fix_objects() function.

commit 5e8d18c2ec676448d02391b1fe96f1d24f328027
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Oct 27 16:55:03 2021 +0200

    Remove now useless fixers
    
    keep the the fix_objects() function for bw compat for now.

commit 627a8a82c6b5496a2d6aec416a359b8bb360c124
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 26 16:38:26 2021 +0200

    Add a --type option to 'swh storage replay'
    
    allows to choose replayed object types from the cli.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1481/ for more details.

Harbormaster completed remote builds in B24911: Diff 24037.Nov 8 2021, 3:35 PM
douardda updated this revision to Diff 24086.Nov 9 2021, 4:38 PM

rebase

swh-public-ci added a comment.Nov 9 2021, 4:46 PM

Build has FAILED

Patch application report for D6570 (id=24086)

Could not rebase; Attempt merge onto 0262f1c191...

Updating 0262f1c1..04bd15a0
Fast-forward
 swh/storage/cli.py            |  31 ++++-
 swh/storage/fixer.py          | 290 ++----------------------------------------
 swh/storage/tests/test_cli.py |  14 ++
 3 files changed, 56 insertions(+), 279 deletions(-)
Changes applied before test
commit 04bd15a0bca87fc21139ffdccd322b5e17fa959e
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Oct 27 16:56:53 2021 +0200

    Refactor fixer.fix_objects() to extract the inner object_fixers dict
    
    allowing to use this dict independently of the fix_objects() function.

commit d655c8581d3c3a522ba083ee309157c4786e2de0
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Oct 27 16:55:03 2021 +0200

    Remove now useless fixers
    
    keep the the fix_objects() function for bw compat for now.

commit 55eed77b519c4c3fc22b95554afa3343e013a253
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 26 16:38:26 2021 +0200

    Add a --type option to 'swh storage replay'
    
    allows to choose replayed object types from the cli.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1487/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1487/console

Harbormaster failed remote builds in B24961: Diff 24086!Nov 9 2021, 4:46 PM
swh-public-ci added a comment.Nov 9 2021, 5:18 PM

Build was aborted

Patch application report for D6570 (id=24086)

Could not rebase; Attempt merge onto 0262f1c191...

Updating 0262f1c1..04bd15a0
Fast-forward
 swh/storage/cli.py            |  31 ++++-
 swh/storage/fixer.py          | 290 ++----------------------------------------
 swh/storage/tests/test_cli.py |  14 ++
 3 files changed, 56 insertions(+), 279 deletions(-)
Changes applied before test
commit 04bd15a0bca87fc21139ffdccd322b5e17fa959e
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Oct 27 16:56:53 2021 +0200

    Refactor fixer.fix_objects() to extract the inner object_fixers dict
    
    allowing to use this dict independently of the fix_objects() function.

commit d655c8581d3c3a522ba083ee309157c4786e2de0
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Oct 27 16:55:03 2021 +0200

    Remove now useless fixers
    
    keep the the fix_objects() function for bw compat for now.

commit 55eed77b519c4c3fc22b95554afa3343e013a253
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 26 16:38:26 2021 +0200

    Add a --type option to 'swh storage replay'
    
    allows to choose replayed object types from the cli.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1489/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1489/console

swh-public-ci added a comment.Nov 9 2021, 5:26 PM

Build is green

Patch application report for D6570 (id=24086)

Could not rebase; Attempt merge onto 0262f1c191...

Updating 0262f1c1..04bd15a0
Fast-forward
 swh/storage/cli.py            |  31 ++++-
 swh/storage/fixer.py          | 290 ++----------------------------------------
 swh/storage/tests/test_cli.py |  14 ++
 3 files changed, 56 insertions(+), 279 deletions(-)
Changes applied before test
commit 04bd15a0bca87fc21139ffdccd322b5e17fa959e
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Oct 27 16:56:53 2021 +0200

    Refactor fixer.fix_objects() to extract the inner object_fixers dict
    
    allowing to use this dict independently of the fix_objects() function.

commit d655c8581d3c3a522ba083ee309157c4786e2de0
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Oct 27 16:55:03 2021 +0200

    Remove now useless fixers
    
    keep the the fix_objects() function for bw compat for now.

commit 55eed77b519c4c3fc22b95554afa3343e013a253
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 26 16:38:26 2021 +0200

    Add a --type option to 'swh storage replay'
    
    allows to choose replayed object types from the cli.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1490/ for more details.

Harbormaster completed remote builds in B24961: Diff 24086.Nov 9 2021, 5:26 PM
Closed by commit rDSTOd655c8581d3c: Remove now useless fixers (authored by douardda). · Explain WhyNov 9 2021, 5:28 PM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDSTOd655c8581d3c: Remove now useless fixers.
douardda added a commit: rDSTO04bd15a0bca8: Refactor fixer.fix_objects() to extract the inner object_fixers dict.

Revision Contents
Changeset List

PathSize
swh/
storage/
274 lines

Diff 24089

View Options

swh/storage/fixer.py

Loading...
About · Developer information · Legal