Build is green
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jul 1 2020
Jul 1 2020
swh-public-ci added a comment to D3384: service/snapshot_count_branches: Improve empty snapshot detection.
Build has FAILED
Harbormaster failed remote builds in B13232: Diff 12013 for D3384: service/snapshot_count_branches: Improve empty snapshot detection!
swh-public-ci added a comment to D3384: service/snapshot_count_branches: Improve empty snapshot detection.
Build has FAILED
anlambert updated the diff for D3384: service/snapshot_count_branches: Improve empty snapshot detection.
Rebase
ardumont updated the task description for T2471: NPM package angular-ts-manage fails to be properly loaded.
This origin (and others) also fails to be mirrored with errors like:
Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org> committed rDSTO28344a0bb758: Merge tag 'debian/0.9.0-1_swh1' into debian/buster-swh (authored by Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org>).
Merge tag 'debian/0.9.0-1_swh1' into debian/buster-swh
Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org> committed rDSTO90c9772bc838: Updated backport on buster-swh from debian/0.9.0-1_swh1 (unstable-swh) (authored by Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org>).
Updated backport on buster-swh from debian/0.9.0-1_swh1 (unstable-swh)
Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org> committed rDSTO204a4efce7ae: pristine-tar data for swh-storage_0.9.0.orig.tar.gz (authored by Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org>).
pristine-tar data for swh-storage_0.9.0.orig.tar.gz
Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org> committed rDSTO74fba45e645f: Updated debian changelog for version 0.9.0 (authored by Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org>).
Updated debian changelog for version 0.9.0
Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org> committed rDSTO80cf105406c1: New upstream version 0.9.0 (authored by Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org>).
New upstream version 0.9.0
Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org> committed rDSTOa1d68e7a703d: Update upstream source from tag 'debian/upstream/0.9.0' (authored by Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org>).
Update upstream source from tag 'debian/upstream/0.9.0'
anlambert updated the summary of D3385: origin_visits/get_origin_visit: Improve default visit picking strategy.
Jun 30 2020
Jun 30 2020
swh-public-ci added a comment to D3385: origin_visits/get_origin_visit: Improve default visit picking strategy.
Build is green
ardumont committed rDWAPPSf433684afd32: Migrate to Use the object's object_type field (authored by ardumont).
Migrate to Use the object's object_type field
Build is green
Adapt according to review.
swh-public-ci added a comment to D3384: service/snapshot_count_branches: Improve empty snapshot detection.
Build is green
swh-public-ci added a comment to D3384: service/snapshot_count_branches: Improve empty snapshot detection.
Build is green
anlambert updated the diff for D3384: service/snapshot_count_branches: Improve empty snapshot detection.
Fix typo in commit message
anlambert updated the summary of D3384: service/snapshot_count_branches: Improve empty snapshot detection.
In D3373#83135, @anlambert wrote:Ok got it, turns out from_disk.Directory.from_disk does not return swh.model.model objects but swh.model.from_disk ones. Those does not have the object_type field thus the AttributeError.
Renaming the type field of those classes to object_type will fix the issue.
Ok got it, turns out from_disk.Directory.from_disk does not return swh.model.model objects but swh.model.from_disk ones. Those does not have the object_type field thus the AttributeError.
So it seems D3375 did not fix the issue after all, jeez
Traceback (most recent call last):
File "/usr/lib/python3.7/wsgiref/handlers.py", line 137, in run
self.result = application(self.environ, self.start_response)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/wsgi.py", line 141, in __call__
response = self.get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/base.py", line 75, in get_response
response = self._middleware_chain(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
response = response_for_exception(request, exc)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/utils/deprecation.py", line 94, in __call__
response = response or self.get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
response = response_for_exception(request, exc)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/utils/deprecation.py", line 94, in __call__
response = response or self.get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
response = response_for_exception(request, exc)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/utils/deprecation.py", line 94, in __call__
response = response or self.get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
response = response_for_exception(request, exc)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/utils/deprecation.py", line 94, in __call__
response = response or self.get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
response = response_for_exception(request, exc)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/utils/deprecation.py", line 94, in __call__
response = response or self.get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
response = response_for_exception(request, exc)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/utils/deprecation.py", line 94, in __call__
response = response or self.get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
response = response_for_exception(request, exc)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/utils/deprecation.py", line 94, in __call__
response = response or self.get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
response = response_for_exception(request, exc)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/antoine/swh/swh-environment/swh-web/swh/web/auth/middlewares.py", line 33, in __call__
return self.get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
response = response_for_exception(request, exc)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/utils/deprecation.py", line 94, in __call__
response = response or self.get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
response = response_for_exception(request, exc)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/utils/deprecation.py", line 94, in __call__
response = response or self.get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
response = response_for_exception(request, exc)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/antoine/swh/swh-environment/swh-web/swh/web/common/middlewares.py", line 66, in __call__
resp = self.get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
response = response_for_exception(request, exc)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/base.py", line 115, in _get_response
response = self.process_exception_by_middleware(e, request)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/core/handlers/base.py", line 113, in _get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
return view_func(*args, **kwargs)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/django/views/generic/base.py", line 71, in view
return self.dispatch(request, *args, **kwargs)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/rest_framework/views.py", line 505, in dispatch
response = self.handle_exception(exc)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/rest_framework/views.py", line 465, in handle_exception
self.raise_uncaught_exception(exc)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/rest_framework/views.py", line 476, in raise_uncaught_exception
raise exc
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/rest_framework/views.py", line 502, in dispatch
response = handler(request, *args, **kwargs)
File "/home/antoine/.virtualenvs/swh/lib/python3.7/site-packages/rest_framework/decorators.py", line 50, in handler
return func(*args, **kwargs)
File "/home/antoine/swh/swh-environment/swh-web/swh/web/tests/views.py", line 107, in get_content_code_data_all_exts
_init_content_code_data_exts()
File "/home/antoine/swh/swh-environment/swh-web/swh/web/tests/views.py", line 73, in _init_content_code_data_exts
"resources/contents/code/extensions", _content_code_data_exts, True
File "/home/antoine/swh/swh-environment/swh-web/swh/web/tests/views.py", line 48, in _init_content_tests_data
if obj.object_type in [Content.object_type, DiskBackedContent.object_type]:
AttributeError: 'Content' object has no attribute 'object_type'Harbormaster failed remote builds in B13226: Diff 12007 for D3383: Implement {directory,revision,release,snapshot}_metadata_{add,get}.!
swh-public-ci added a comment to D3383: Implement {directory,revision,release,snapshot}_metadata_{add,get}..
Build has FAILED
Build is green
Harbormaster failed remote builds in B13224: Diff 12005 for D3373: webapp: Migrate to Use the object's object_type field!
Build was aborted
Rebase (hopefully the build won't get stuck ;)
anlambert committed rDWAPPS91f81bb1e49a: templates/admin/origin-save: Fix missing save bundle inclusion (authored by anlambert).
templates/admin/origin-save: Fix missing save bundle inclusion
ardumont committed rDSTO312127af7ce3: storage*: Drop intermediary conversion step into OriginVisit (authored by ardumont).
storage*: Drop intermediary conversion step into OriginVisit
swh-public-ci added a comment to D3381: templates/admin/origin-save: Fix missing save bundle inclusion.
Build is green
swh-public-ci added a comment to D3380: storage*: Drop intermediary conversion step into OriginVisit.
Build is green
anlambert lowered the priority of T2283: "Vault Status" page doesn't get updated when asking for email notifications from High to Normal.
I still can not reproduce the issue. Keeping that task opened in case someone else encounters it but I am raising down the priority of that task.
Build was aborted
Harbormaster failed remote builds in B13219: Diff 12000 for D3380: storage*: Drop intermediary conversion step into OriginVisit!
swh-public-ci added a comment to D3380: storage*: Drop intermediary conversion step into OriginVisit.
Build was aborted
Harbormaster failed remote builds in B13218: Diff 11999 for D3380: storage*: Drop intermediary conversion step into OriginVisit!
swh-public-ci added a comment to D3380: storage*: Drop intermediary conversion step into OriginVisit.
Build was aborted
Really drop the swh.model version bump (i did update to 3.5 by mistake when
reverting manually :/)
Rebase on latest master
ardumont added inline comments to D3380: storage*: Drop intermediary conversion step into OriginVisit.
ardumont updated the summary of D3380: storage*: Drop intermediary conversion step into OriginVisit.
- Fix typo (thx)
vlorentz committed rDSTO953bd29ab04e: pg: use 'on conflict do nothing' strategy for duplicate metadata rows. (authored by vlorentz).
pg: use 'on conflict do nothing' strategy for duplicate metadata rows.
vlorentz committed rDSTO00f97f082e8e: Document the behavior of adding a duplicate non-intrinsic object is unspecified. (authored by vlorentz).
Document the behavior of adding a duplicate non-intrinsic object is unspecified.
vlorentz committed rDSTO4c2bdadd3536: Make the code location of metadata endpoints consistent across backends. (authored by vlorentz).
Make the code location of metadata endpoints consistent across backends.
ardumont accepted D3378: Document the behavior of adding a duplicate non-intrinsic object is unspecified..
Thanks.
ardumont updated the test plan for D3380: storage*: Drop intermediary conversion step into OriginVisit.
anlambert closed T2276: Web API: /known: add a length limit to the list of accepted PID as Resolved.
Harbormaster failed remote builds in B13214: Diff 11995 for D3380: storage*: Drop intermediary conversion step into OriginVisit!
swh-public-ci added a comment to D3380: storage*: Drop intermediary conversion step into OriginVisit.
Build has FAILED
ardumont updated the test plan for D3380: storage*: Drop intermediary conversion step into OriginVisit.
swh-public-ci added a comment to D3379: pg: use 'on conflict do nothing' strategy for duplicate metadata rows..
Build is green
vlorentz updated the diff for D3379: pg: use 'on conflict do nothing' strategy for duplicate metadata rows..
add comments
swh-public-ci added a comment to D3379: pg: use 'on conflict do nothing' strategy for duplicate metadata rows..
Build is green
swh-public-ci added a comment to D3379: pg: use 'on conflict do nothing' strategy for duplicate metadata rows..
Build is green
vlorentz updated the diff for D3379: pg: use 'on conflict do nothing' strategy for duplicate metadata rows..
explain the motivation in the commit message
swh-public-ci added a comment to D3378: Document the behavior of adding a duplicate non-intrinsic object is unspecified..
Build is green
swh-public-ci added a comment to D3377: Make the code location of metadata endpoints consistent across backends..
Build is green
But they have to be taken into account when writing the OpenAPI description of the API, if that's what you meant
Items 5, 6, 7 aka pagination, auth and batches - I believe these come naturally with item 4 (specification wise)
Build was aborted
I suspect when this task was initially submitted we didn't have yet SWHID with qualifiers :)
From the point of view of the APIv2, given v1 was using only hashes, for feature parity we should indeed only need SWHID without qualifiers, i.e., "core" SWHIDs. (I'm gonna edit the task description to reflect that.) Thanks for noticing this!
Rereading this task, I have a few comments/questions.