Page MenuHomeSoftware Heritage

Implement {directory,revision,release,snapshot}_metadata_{add,get}.
AbandonedPublic

Authored by vlorentz on Tue, Jun 30, 4:52 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

Depends on D3382.

Diff Detail

Repository
rDSTO Storage manager
Branch
monomorphize-object-metadata
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13226
Build 20195: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 20194: arc lint + arc unit

Unit TestsFailed

TimeTest
1,386 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_api_client.TestStorage::test_types
self = <swh.storage.tests.test_api_client.TestStorage object at 0x7fa934ab85c0> swh_storage_backend_config = {'cls': 'local', 'db': 'postgresql://postgres@127.0.0.1:22512/tests', 'journal_writer': {'cls': 'memory'}, 'objstorage': {'args': {}, 'cls': 'memory'}}
203 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_storage.TestStorage::test_types
self = <swh.storage.tests.test_storage.TestStorage object at 0x7fa728c24470> swh_storage_backend_config = {'cls': 'local', 'db': 'postgresql://postgres@127.0.0.1:22512/tests', 'journal_writer': {'cls': 'memory'}, 'objstorage': {'args': {}, 'cls': 'memory'}}
6 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_content
2 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_origin
4 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_origin_visit
View Full Test Results (2 Failed · 890 Passed · 17 Skipped)

Event Timeline

vlorentz created this revision.Tue, Jun 30, 4:52 PM

Build has FAILED

Patch application report for D3383 (id=12007)

Could not rebase; Attempt merge onto 312127af7c...

Auto-merging swh/storage/storage.py
Auto-merging swh/storage/in_memory.py
Auto-merging swh/storage/cassandra/storage.py
Merge made by the 'recursive' strategy.
 swh/storage/cassandra/storage.py  | 132 ++++++
 swh/storage/in_memory.py          | 132 ++++++
 swh/storage/interface.py          | 276 +++++++++++++
 swh/storage/storage.py            | 160 +++++++-
 swh/storage/tests/storage_data.py | 224 ++++++++++
 swh/storage/tests/test_storage.py | 840 ++++++++++++++++++++++++++++++++++++--
 6 files changed, 1706 insertions(+), 58 deletions(-)
Changes applied before test
commit b89481156fdc4b95e6afedce4fc4af9f6c5fefd9
Merge: 312127af 7275fcee
Author: Jenkins user <jenkins@localhost>
Date:   Tue Jun 30 14:58:32 2020 +0000

    Merge branch 'diff-target' into HEAD

commit 7275fceeecf785ec4502754fcbfc56136b54fbcd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 30 16:52:38 2020 +0200

    Implement {directory,revision,release,snapshot}_metadata_{add,get}.

commit c46d3e3d0e00251dd1ba830f6dcaa3abbf0071bf
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 30 16:35:59 2020 +0200

    Move tests of content_metadata_* next to origin_metadata_*
    
    For consistency with the main code.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/405/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/405/console

vlorentz abandoned this revision.Thu, Jul 2, 11:11 AM

I'll rewrite this using swh-model and only two endpoints for all types

I'll rewrite this using swh-model and only two endpoints for all types

ack (you could have kept the diff, marking pending changes heh ;)