Differential D3386

Test to reproduce issue
AbandonedPublic
Actions

Authored by ardumont on Jul 1 2020, 11:25 AM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T2471: NPM package angular-ts-manage fails to be properly loaded

Summary

Don't have the fix yet. Just reproducing the issue referenced in the task.

Right now, the json is loaded without issues.
It's only when trying to write within the storage that error are detected.

This issue is within the realm of the npm loader so i'm more inclined toward
fixing that behavior there instead of the storage.

Related to T2471

Test Plan

tox
(at some point should be green ;)

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13233
Build 20208: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20207: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	263 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.package.npm.tests.test_npm::test_npm_artifact_json_issues swh_config = '/tmp/pytest-of-jenkins/pytest-0/test_npm_artifact_json_issues0/loader.yml' requests_mock_datadir = <requests_mock.mocker.Mocker object at 0x7f9c7911fe48>
	2 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_content_for_storage_data
	7 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_content_for_storage_path
	3 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_content_for_storage_too_long
	3 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_prepare_contents
		View Full Test Results (1 Failed · 139 Passed)

Event Timeline

ardumont created this revision.Jul 1 2020, 11:25 AM

ardumont planned changes to this revision.Jul 1 2020, 11:26 AM

ardumont added inline comments.

swh/loader/package/npm/tests/data/https_replicate.npmjs.com/jammit-express-json-issue
13	here and within the corresponding package.json in the associated artifact. Because both ends up in the revision metadata field for now. So they should both be sanitized.

Build has FAILED

Patch application report for D3386 (id=12015)

Rebasing onto 316f9129dc...

Current branch diff-target is up to date.

Changes applied before test

commit 9409d106b2fbfe0454cd919d7c8be86b2d5e925d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 1 11:24:55 2020 +0200

    Test to reproduce issue
    
    Related to T2471

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/92/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/92/console

Harbormaster failed remote builds in B13233: Diff 12015!Jul 1 2020, 11:27 AM

ardumont edited the summary of this revision. (Show Details)Jul 1 2020, 12:08 PM

Agreed on irc that the priority of the task can be decreased, this: