Preferred solution: D3126
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 5 2020
In D3122#75850, @vlorentz wrote:why was get_journal_client removed from swh.journal.cli?
All the code you're adding in swh/search/cli.py should be in swh-journal, so it can be used by other CLIs using a journal client
nice work! thx
May 4 2020
I'd like one or 2 comments (as stated in the comment above), and I don't like the inheritance between PrefixedAzureCloudObjStorage and AzureCloudObjStorage, but that's not the object of this diff.
Apr 30 2020
Let's consider this is done now.
Apr 29 2020
closed by d33d009d1fb9b89d47df3476c7da86c88b1d4035
Apr 28 2020
correct django pinning
fixes according to comments
In D3073#74847, @anlambert wrote:While individual doc build can still be launched in each subproject, I am fine with it.
trigger jenkins (maybe)
trigger jenkins
update index.rst
and remaining references to the storage fixture in test_cli...
forgot tox.ini
fixes according to anlambert's comments
Apr 27 2020
closed by 3043177f79b24d2c5791c3196bd17116f83086bc
update copyright dates of modifed files + fix a typo
Apr 24 2020
rebase
clean import statements in test_cli.py
rebase
rebase + add forgotten test_kafka_writer test file
Adapt according to ardumont's comments
looks fine to me, but the few minor comments. I'll let @vlorentz gives his green stamp on this.
Apr 23 2020
rebased
yet more comments
Add more comments in the convoluted test code
ok but IMHO something should be done, some day, to "normalize" also this command so it accepts the "standard" configuration scheme (via --config-file or the SWH_CONFIG_FILE env var). But that's another task. Thanks for the fix.