Page MenuHomeSoftware Heritage
Differential D1427

setup: extract db and http related parts in dedicated optional 'extras'
ClosedPublic
Actions

Authored by douardda on Apr 19 2019, 12:13 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T1678: Make the swh.core package define some 'extras' features to limit dependencies of the 'plain' swh.core package
Commits
rDCORE86eeb30ffd0e: setup: extract db and http related parts to dedicated optional 'extras'
rDCOREa057ad05c021: logger: kill the (now unused) PostresHandler
Summary

Note that for now, the main requirements.txt still contains all the
dependencies for backward compatibility reasons.
This will have to be fixed once all packages that depends on swh.core
have been updated.

Also kill the PostgresHandler logging handler.

closes T1678.

depends on D1426.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Branch
current
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 5584
Build 7609: tox-on-jenkinsJenkins
Build 7608: arc lint + arc unit

Event Timeline

douardda created this revision.Apr 19 2019, 12:13 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 19 2019, 12:13 PM
swh-public-ci added a comment.Apr 19 2019, 12:18 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/205/ for more details.

Harbormaster completed remote builds in B5513: Diff 4634.Apr 19 2019, 12:18 PM
zack retitled this revision from logger: extract the PostresHandler in a dedicated module to logger: extract the PostgresHandler to a dedicated module.Apr 19 2019, 12:36 PM
douardda updated this revision to Diff 4635.Apr 19 2019, 2:31 PM

Fix commit messages

Harbormaster completed remote builds in B5514: Diff 4635.Apr 19 2019, 2:34 PM
swh-public-ci added a comment.Apr 19 2019, 2:34 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/207/ for more details.

olasd added a subscriber: olasd.Apr 19 2019, 3:18 PM

The PostgresHandler has been dead code for two years, I think we can just remove it rather than shuffling it around.

douardda added a comment.Apr 19 2019, 3:28 PM
In D1427#31359, @olasd wrote:

The PostgresHandler has been dead code for two years, I think we can just remove it rather than shuffling it around.

That's good news!

douardda updated this revision to Diff 4639.Apr 19 2019, 3:36 PM

kill the PostresHandler instead of "shuffling it around" (© olasd)

douardda retitled this revision from logger: extract the PostgresHandler to a dedicated module to setup: extract db and http related parts in dedicated optional 'extras'.Apr 19 2019, 3:37 PM
douardda edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Apr 19 2019, 3:38 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/208/ for more details.

Harbormaster completed remote builds in B5518: Diff 4639.Apr 19 2019, 3:38 PM
douardda updated this revision to Diff 4683.May 2 2019, 3:20 PM

rebase

swh-public-ci added a comment.May 2 2019, 3:23 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/211/ for more details.

Harbormaster completed remote builds in B5566: Diff 4683.May 2 2019, 3:23 PM
douardda added a child revision: D1439: cli: make swh-scheduler a subcommand of swh.core's main "swh" command.May 2 2019, 5:42 PM
vlorentz added a subscriber: vlorentz.May 6 2019, 11:46 AM

Shouldn't we add tests to make sure that core features work without the extras?

douardda added a comment.May 6 2019, 1:42 PM
In D1427#31768, @vlorentz wrote:

Shouldn't we add tests to make sure that core features work without the extras?

yeah that's something I had in mind, but not sure how to test it without depending on venvs/tox ("raw" pytest)...

douardda added a comment.May 6 2019, 1:44 PM
In D1427#31806, @douardda wrote:
In D1427#31768, @vlorentz wrote:

Shouldn't we add tests to make sure that core features work without the extras?

yeah that's something I had in mind, but not sure how to test it without depending on venvs/tox ("raw" pytest)...

Maybe having this "distribution" aspect tested only in tox is enough, isn't it?

vlorentz added a comment.May 6 2019, 1:45 PM

I think it is.

ardumont accepted this revision.May 6 2019, 2:13 PM
This revision is now accepted and ready to land.May 6 2019, 2:13 PM
douardda updated this revision to Diff 4700.May 6 2019, 3:22 PM

rebased

This revision was landed with ongoing or failed builds.May 6 2019, 3:23 PM
Closed by commit rDCOREa057ad05c021: logger: kill the (now unused) PostresHandler (authored by douardda). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B5584: Diff 4700!May 6 2019, 3:24 PM
swh-public-ci added a comment.May 6 2019, 3:24 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/213/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/213/console

Revision Contents
Changeset List

PathSize
2 lines
requirements-http.txt
requirements.txt
11 lines
8 lines
37 lines
swh/
core/
88 lines
tests/

Diff 4700

View Options

requirements-db.txt

Loading...
View Options

requirements-http.txt

Loading...
View Options

requirements.txt

Loading...
View Options

setup.py

Loading...
View Options

swh/core/logger.py

Loading...
View Options

swh/core/tests/test_logger.py

Loading...
About · Developer information · Legal