Page MenuHomeSoftware Heritage

setup: extract db and http related parts in dedicated optional 'extras'
ClosedPublic

Authored by douardda on Apr 19 2019, 12:13 PM.

Details

Summary

Note that for now, the main requirements.txt still contains all the
dependencies for backward compatibility reasons.
This will have to be fixed once all packages that depends on swh.core
have been updated.

Also kill the PostgresHandler logging handler.

closes T1678.

depends on D1426.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Branch
current
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 5513
Build 7488: tox-on-jenkinsJenkins
Build 7487: arc lint + arc unit

Event Timeline

zack retitled this revision from logger: extract the PostresHandler in a dedicated module to logger: extract the PostgresHandler to a dedicated module.Apr 19 2019, 12:36 PM

The PostgresHandler has been dead code for two years, I think we can just remove it rather than shuffling it around.

In D1427#31359, @olasd wrote:

The PostgresHandler has been dead code for two years, I think we can just remove it rather than shuffling it around.

That's good news!

kill the PostresHandler instead of "shuffling it around" (© olasd)

douardda retitled this revision from logger: extract the PostgresHandler to a dedicated module to setup: extract db and http related parts in dedicated optional 'extras'.Apr 19 2019, 3:37 PM
douardda edited the summary of this revision. (Show Details)

Shouldn't we add tests to make sure that core features work without the extras?

Shouldn't we add tests to make sure that core features work without the extras?

yeah that's something I had in mind, but not sure how to test it without depending on venvs/tox ("raw" pytest)...

Shouldn't we add tests to make sure that core features work without the extras?

yeah that's something I had in mind, but not sure how to test it without depending on venvs/tox ("raw" pytest)...

Maybe having this "distribution" aspect tested only in tox is enough, isn't it?

This revision is now accepted and ready to land.May 6 2019, 2:13 PM
This revision was landed with ongoing or failed builds.May 6 2019, 3:23 PM
This revision was automatically updated to reflect the committed changes.