Page MenuHomeSoftware Heritage
Create Task
Maniphest T366

Refactor the person table
Closed, MigratedEdits Locked
Actions

Description

It appears that the author specifications in some git commits are more free form than name <email>:

  • some omit the name and keep the space ( <email>)
  • some omit the name and the space (<email>)
  • some have trailing spaces (name <email> )

I believe our way out is adding a fullname field to the person table, and making the name and email field "secondary" fields that are filled if we were able to parse the fullname.

Revisions and Commits

rDSTO Storage manager
rDSTO740bef462123 sql/swh-schema: add a fullname field to person
rDOBJS Object storage
D67rDOBJS355e30dabdbd sql/swh-schema: add a fullname field to person

Related Objects
Search...

StatusAssignedTask
 Migratedgitlab-migrationT3096 Efficient and reliable download via the Vault
 Migratedgitlab-migrationT3135 Improve integrity of ingested content
 Migratedgitlab-migrationT399 (Re-)Compute data checksums before insertion
 Migratedgitlab-migrationT3010 Enable the validating storage proxy in production
 Migratedgitlab-migrationT887 Vault: "snapshot" cooker
 Migratedgitlab-migrationT3504 Make the git-bare cooker publicly available
 Migratedgitlab-migrationT3505 Make the git-bare cooker available to the staff and beta-testers in the production webapp
 Migratedgitlab-migrationT3506 Get rid of the concept of vault "object_type"
 Migratedgitlab-migrationT3507 prod: vault: Deploy v1.0.0
 Migratedgitlab-migrationT3503 staging: vault: Deploy v1.0.0
 Migratedgitlab-migrationT843 Vault: Add a "git bare" tarball cooker
 Migratedgitlab-migrationT3412 Deploy vault "git bare" tarball cooker (swh-vault v0.6)
 Migratedgitlab-migrationT3518 Enable vault cookers to access swh-graph
 Migratedgitlab-migrationT3543 Debian package python3-swh.graph.client
 Migratedgitlab-migrationT3565 Add an option in swh-web to allow git-bare cooking via the UI for beta-testers
 Migratedgitlab-migrationT3551 Fix git-fsck errors in the git-bare cooker
 Migratedgitlab-migrationT3552 Fix corrupted releases, revisions, and directories in the storage
 Migratedgitlab-migrationT3566 git-fsck errors in the git-bare cooker are not properly reported
 Migratedgitlab-migrationT3731 Try parallelizing directory_get_entries with an async swh-storage client
 Migratedgitlab-migrationT3924 Write mailmaps after cooking git-bare archives with display names?
 Migratedgitlab-migrationT3860 Document types/sources of object corruption
 Migratedgitlab-migrationT75 Check integrity of directories, revisions, and releases
 Migratedgitlab-migrationT366 Refactor the person table

Event Timeline

olasd created this task.Apr 7 2016, 2:28 PM
zack added a comment.Apr 7 2016, 2:42 PM

after F2F discussion: ACK! /o\

  • id remains PRIMARY KEY
  • fullname is a new column, UNIQUE
  • name and email are NULLABLE, and filled only if we can parse them (note: empty string != NULL here, and both are meaningful)
olasd closed this task as Resolved by committing rDSTO740bef462123: sql/swh-schema: add a fullname field to person.Apr 7 2016, 6:30 PM
olasd added a commit: rDSTO740bef462123: sql/swh-schema: add a fullname field to person.
olasd changed the visibility from "All Users" to "Public (No Login Required)".May 13 2016, 5:09 PM
qcampos added a commit: rDOBJS355e30dabdbd: sql/swh-schema: add a fullname field to person.Jun 27 2016, 1:45 PM
gitlab-migration changed the task status from Resolved to Migrated.Jan 8 2023, 4:18 PM
gitlab-migration claimed this task.
gitlab-migration added a subscriber: gitlab-migration.

This task has been migrated to GitLab.

About · Developer information · Legal