Page MenuHomeSoftware Heritage
Differential D827

Remove mocks and use hypothesis in api content endpoints tests
ClosedPublic
Actions

Authored by anlambert on Dec 14 2018, 6:43 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
R65:3905ab0e9008: tests.api.views.test_content: Remove mocks and use hypothesis
rDWAPPS3905ab0e9008: tests.api.views.test_content: Remove mocks and use hypothesis
Summary

Third diff exposing the work I have done so far on improving swh-web tests.
In this one, let's start to remove the mocks by rewriting the tests
using hypothesis for the content endpoints in the web api.

Related T1271

Depends on D826

Diff Detail

Repository
rDWAPPS Web applications
Branch
tests-improvements-diff3
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3112
Build 3981: tox-on-jenkinsJenkins
Build 3980: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 14 2018, 6:43 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 14 2018, 6:43 PM
Harbormaster failed remote builds in B3057: Diff 2627!Dec 14 2018, 6:44 PM
swh-public-ci added a subscriber: swh-public-ci.Dec 14 2018, 6:44 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/44/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/44/console

anlambert added a child revision: D828: Remove mocks and use hypothesis in api directory endpoints tests.Dec 14 2018, 7:17 PM
vlorentz added a subscriber: vlorentz.Dec 14 2018, 7:35 PM
vlorentz added inline comments.
swh/web/tests/api/views/test_content.py
103–120

This can probably be factorized in a for loop.

208–228

same

vlorentz added inline comments.Dec 14 2018, 7:38 PM
swh/web/tests/api/views/test_content.py
83–99

This condition is computed twice, it should be a class variable or a global instead.

152–160

same

anlambert retitled this revision from swh-web: Remove mocks and use hypothesis in api content endpoints tests to Remove mocks and use hypothesis in api content endpoints tests.Dec 17 2018, 10:43 AM
anlambert updated this revision to Diff 2671.Dec 17 2018, 4:40 PM

Rebase after D825 and D826 updates

Harbormaster failed remote builds in B3105: Diff 2671!Dec 17 2018, 4:41 PM
swh-public-ci added a comment.Dec 17 2018, 4:41 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/49/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/49/console

anlambert updated this revision to Diff 2678.Dec 17 2018, 5:22 PM

Update: Rebase after D826 update and use variables to skip some tests

Harbormaster failed remote builds in B3112: Diff 2678!Dec 17 2018, 5:24 PM
swh-public-ci added a comment.Dec 17 2018, 5:24 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/53/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/53/console

anlambert updated this revision to Diff 2690.Dec 18 2018, 2:34 PM

Update: factorize some code using for loops

Harbormaster failed remote builds in B3122: Diff 2690!Dec 18 2018, 2:35 PM
swh-public-ci added a comment.Dec 18 2018, 2:35 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/56/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/56/console

ardumont accepted this revision.Dec 18 2018, 2:45 PM
This revision is now accepted and ready to land.Dec 18 2018, 2:45 PM
anlambert updated this revision to Diff 2699.Dec 18 2018, 3:03 PM

Rebase

Harbormaster failed remote builds in B3131: Diff 2699!Dec 18 2018, 3:06 PM
swh-public-ci added a comment.Dec 18 2018, 3:06 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/60/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/60/console

Closed by commit rDWAPPS3905ab0e9008: tests.api.views.test_content: Remove mocks and use hypothesis (authored by anlambert). · Explain WhyDec 18 2018, 3:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
web/
tests/
api/
views/
714 lines

Diff 2678

View Options

swh/web/tests/api/views/test_content.py

Loading...
About · Developer information · Legal