Use the in-memory storage instead of mocks to test the webapp
Closed, MigratedEdits Locked
Actions

Assigned To

Authored By

	anlambert
	Oct 17 2018, 1:47 PM

Description

Currently, the unit tests of swh-web heavily rely on mocking the methods of the swh.storage.Storage class.
While the approach works, there is a couple of drawbacks with it:

tests implementation are hard to read and maintain for a newcomer
tests data are hardcoded and can end up not synchronized with the latest swh-storage schema
maintaining tests full of mocks is painful and too much time consuming

These tests must be rewritten using the new in-memory storage.

Revisions and Commits

rDWAPPS Web applications
	rDWAPPSf162d26f4ff7 tests.browse.revision: Remove mocks and use hypothesis

Related Objects
Search...

Status	Assigned	Task
Migrated	gitlab-migration	T1422 drop swh-storage mocking everywhere
Migrated	gitlab-migration	T1421 drop swh-storage mocking everywhere
Migrated	gitlab-migration	T1307 Remove mock storages used in tests.
Migrated	gitlab-migration	T1271 Use the in-memory storage instead of mocks to test the webapp

Event Timeline

anlambert triaged this task as Normal priority.Oct 17 2018, 1:47 PM

anlambert created this task.

Now that the backend storage API has been trimmed way down, I think implementing an in-memory implementation of its API is becoming tractable again. This would help avoid using a SQL database for integration testing of other components of the stack.

This is sort of what is being done with the test fixture for the loaders, but pushed one layer lower in the stack.

anlambert updated the task description. (Show Details)Oct 17 2018, 1:55 PM

anlambert renamed this task from Web app: Find a way to run tests without mocking storage to Use the in-mem storage instead of mocks to test the webapp..Nov 21 2018, 11:02 AM

anlambert claimed this task.

anlambert updated the task description. (Show Details)

anlambert added a parent task: T1307: Remove mock storages used in tests..

anlambert renamed this task from Use the in-mem storage instead of mocks to test the webapp. to Use the in-mem storage instead of mocks to test the webapp.Nov 21 2018, 12:01 PM

anlambert changed the task status from Open to Work in Progress.Dec 7 2018, 10:49 AM

anlambert renamed this task from Use the in-mem storage instead of mocks to test the webapp to Use the in-memory storage instead of mocks to test the webapp.Dec 11 2018, 10:46 AM

anlambert updated the task description. (Show Details)

anlambert mentioned this in D825: Add module to generate relevant data as tests input.Dec 14 2018, 6:15 PM

anlambert mentioned this in D826: Add hypothesis strategies and enrich WebTestCase.Dec 14 2018, 6:22 PM

anlambert mentioned this in D827: Remove mocks and use hypothesis in api content endpoints tests.Dec 14 2018, 6:43 PM

anlambert mentioned this in D828: Remove mocks and use hypothesis in api directory endpoints tests.Dec 14 2018, 7:17 PM

anlambert mentioned this in D829: Remove storage mocks and use hypothesis in service tests.Dec 14 2018, 7:22 PM

anlambert mentioned this in rDWAPPS4c25aa387f5f: tests: Add module to generate relevant data as tests input.Dec 17 2018, 5:17 PM

anlambert mentioned this in rDWAPPScece0014adae: tests: Add hypothesis strategies and enrich WebTestCase.Dec 18 2018, 3:14 PM

anlambert mentioned this in rDWAPPS3905ab0e9008: tests.api.views.test_content: Remove mocks and use hypothesis.

anlambert mentioned this in rDWAPPSdecefe13badc: tests.api.views.test_directory: Remove mocks and use hypothesis.

anlambert mentioned this in D897: storage.in_memory: Add person_get implementation.Jan 8 2019, 2:59 PM

anlambert mentioned this in rDWAPPSb97487bc2b22: tests.common.test_service: Remove storage mocks and use hypothesis.Jan 9 2019, 5:20 PM