Page MenuHomeSoftware Heritage

Remove mocks and use hypothesis in api directory endpoints tests
ClosedPublic

Authored by anlambert on Dec 14 2018, 7:17 PM.

Details

Summary

Fouth diff exposing the work I have done so far on improving swh-web tests.
In this one, remove the mocks by rewriting the tests using hypothesis for the
directory endpoints in the web api.

Related T1271

Depends on D827

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Dec 14 2018, 7:17 PM
vlorentz accepted this revision.Dec 14 2018, 7:39 PM
This revision is now accepted and ready to land.Dec 14 2018, 7:39 PM
ardumont accepted this revision.Dec 15 2018, 9:28 AM
ardumont added a subscriber: ardumont.

That's cool.

And in the end that was not 'removing the mocks', that was migrating away from them.
Replacing them with something better ;)

That was my initial source of disagreement.

anlambert retitled this revision from swh-web: Remove mocks and use hypothesis in api directory endpoints tests to Remove mocks and use hypothesis in api directory endpoints tests.Dec 17 2018, 10:42 AM
anlambert updated this revision to Diff 2672.Dec 17 2018, 4:41 PM

Rebase after D827 update

anlambert updated this revision to Diff 2679.Dec 17 2018, 5:23 PM

Rebase after D827 update

anlambert updated this revision to Diff 2691.Dec 18 2018, 2:35 PM

Rebase after D827 update

This revision was automatically updated to reflect the committed changes.