Details

Reviewers

vlorentz
ardumont

Group Reviewers

Reviewers

Commits

R65:decefe13badc: tests.api.views.test_directory: Remove mocks and use hypothesis
rDWAPPSdecefe13badc: tests.api.views.test_directory: Remove mocks and use hypothesis

Summary

Fouth diff exposing the work I have done so far on improving swh-web tests.
In this one, remove the mocks by rewriting the tests using hypothesis for the
directory endpoints in the web api.

Related T1271

Depends on D827

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Dec 14 2018, 7:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 14 2018, 7:17 PM

Harbormaster failed remote builds in B3058: Diff 2628!Dec 14 2018, 7:17 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/45/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/45/console

anlambert added a child revision: D829: Remove storage mocks and use hypothesis in service tests.Dec 14 2018, 7:22 PM

vlorentz accepted this revision.Dec 14 2018, 7:39 PM

This revision is now accepted and ready to land.Dec 14 2018, 7:39 PM

That's cool.

And in the end that was not 'removing the mocks', that was migrating away from them.
Replacing them with something better ;)

That was my initial source of disagreement.

anlambert retitled this revision from swh-web: Remove mocks and use hypothesis in api directory endpoints tests to Remove mocks and use hypothesis in api directory endpoints tests.Dec 17 2018, 10:42 AM

Rebase after D827 update

Harbormaster failed remote builds in B3106: Diff 2672!Dec 17 2018, 4:42 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/50/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/50/console