Page MenuHomeSoftware Heritage
Differential D829

Remove storage mocks and use hypothesis in service tests
ClosedPublic
Actions

Authored by anlambert on Dec 14 2018, 7:22 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
R65:b97487bc2b22: tests.common.test_service: Remove storage mocks and use hypothesis
rDWAPPSb97487bc2b22: tests.common.test_service: Remove storage mocks and use hypothesis
Summary

Fifth and last Diff for the moment exposing the work I have done so far on improving swh-web tests.

In this one, remove storage mocks in the service module.

Related T1271

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Dec 14 2018, 7:22 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 14 2018, 7:22 PM
Harbormaster failed remote builds in B3059: Diff 2629!Dec 14 2018, 7:22 PM
swh-public-ci added a subscriber: swh-public-ci.Dec 14 2018, 7:23 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/46/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/46/console

vlorentz accepted this revision.Dec 14 2018, 7:41 PM
This revision is now accepted and ready to land.Dec 14 2018, 7:41 PM
anlambert retitled this revision from [WIP] swh-web: Remove mocks and use hypothesis in service tests to [WIP] Remove mocks and use hypothesis in service tests.Dec 17 2018, 10:42 AM
anlambert updated this revision to Diff 2673.Dec 17 2018, 4:42 PM

Rebase after D828 update

Harbormaster failed remote builds in B3107: Diff 2673!Dec 17 2018, 4:42 PM
swh-public-ci added a comment.Dec 17 2018, 4:43 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/51/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/51/console

anlambert updated this revision to Diff 2680.Dec 17 2018, 5:23 PM

Update: Rebase and use variable to skip ctags test

Harbormaster failed remote builds in B3114: Diff 2680!Dec 17 2018, 5:25 PM
swh-public-ci added a comment.Dec 17 2018, 5:25 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/55/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/55/console

anlambert updated this revision to Diff 2693.Dec 18 2018, 2:35 PM

Rebase after D828 update

Harbormaster failed remote builds in B3125: Diff 2693!Dec 18 2018, 2:36 PM
swh-public-ci added a comment.Dec 18 2018, 2:36 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/58/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/58/console

anlambert updated this revision to Diff 2701.Dec 18 2018, 3:04 PM

Rebase

Harbormaster failed remote builds in B3133: Diff 2701!Dec 18 2018, 3:07 PM
swh-public-ci added a comment.Dec 18 2018, 3:07 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/62/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/62/console

anlambert edited the summary of this revision. (Show Details)Dec 18 2018, 3:15 PM
swh-public-ci added a comment.Dec 18 2018, 3:28 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/63/ for more details.

Harbormaster completed remote builds in B3133: Diff 2701.Dec 18 2018, 3:28 PM
anlambert updated this revision to Diff 2736.Dec 19 2018, 2:49 PM

Update: rebase to master and process new tests

anlambert planned changes to this revision.Dec 19 2018, 2:50 PM
swh-public-ci added a comment.Dec 19 2018, 2:53 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/65/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/65/console

Harbormaster failed remote builds in B3178: Diff 2736!Dec 19 2018, 2:53 PM
anlambert updated this revision to Diff 2738.Dec 19 2018, 4:02 PM

Update: fix ci build, rebase to master and process more tests

This revision is now accepted and ready to land.Dec 19 2018, 4:02 PM
swh-public-ci added a comment.Dec 19 2018, 4:04 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/66/ for more details.

Harbormaster completed remote builds in B3182: Diff 2738.Dec 19 2018, 4:05 PM
anlambert planned changes to this revision.Dec 19 2018, 4:54 PM
anlambert updated this revision to Diff 2816.Jan 7 2019, 5:46 PM

Update: Rebase to master, process a lot of new tests

Still a dozen of tests remaining before the landing of that Diff.

This revision is now accepted and ready to land.Jan 7 2019, 5:46 PM
anlambert planned changes to this revision.Jan 7 2019, 5:48 PM
swh-public-ci added a comment.Jan 7 2019, 5:49 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/67/ for more details.

Harbormaster completed remote builds in B3266: Diff 2816.Jan 7 2019, 5:49 PM
anlambert retitled this revision from [WIP] Remove mocks and use hypothesis in service tests to Remove storage mocks and use hypothesis in service tests.Jan 9 2019, 5:14 PM
anlambert edited the summary of this revision. (Show Details)
anlambert updated this revision to Diff 2858.Jan 9 2019, 5:15 PM

Update: All storage mocks from the service module tests are now removed \o/

This diff should be ready to land.

This revision is now accepted and ready to land.Jan 9 2019, 5:15 PM
swh-public-ci added a comment.Jan 9 2019, 5:19 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/68/ for more details.

Harbormaster completed remote builds in B3318: Diff 2858.Jan 9 2019, 5:19 PM
Closed by commit rDWAPPSb97487bc2b22: tests.common.test_service: Remove storage mocks and use hypothesis (authored by anlambert). · Explain WhyJan 9 2019, 5:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
debian/
4 lines
2 lines
swh/
web/
tests/
common/
2277 lines
16 lines
resources/
repos/
53 lines
21 lines

Diff 2859

View Options

debian/control

Loading...
View Options

requirements-swh.txt

Loading...
View Options

swh/web/tests/common/test_service.py

Loading...
View Options

swh/web/tests/data.py

Loading...
View Options

swh/web/tests/resources/repos/repo_with_submodules.tgz

Loading...
View Options

swh/web/tests/strategies.py

Loading...
View Options

swh/web/tests/testcase.py

Loading...
About · Developer information · Legal