Differential D6935

deposit: Remove 'negative_utc' from test data
ClosedPublic
Actions

Authored by vlorentz on Jan 13 2022, 11:51 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3752: Store/represent time offsets as strings

Commits

rDLDBASEc2d96ed3e461: deposit: Remove 'negative_utc' from test data

Summary

swh-deposit v0.17.0 removes it, to match the removal from swh-model v5.0.0

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 13 2022, 11:51 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 13 2022, 11:51 AM

Build is green

Patch application report for D6935 (id=25123)

Rebasing onto e3d793dec5...

Current branch diff-target is up to date.

Changes applied before test

commit c2d96ed3e4613433171895624acbd54b9be5cb99
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jan 13 11:50:19 2022 +0100

    deposit: Remove 'negative_utc' from test data
    
    swh-deposit v0.17.0 removes it, to match the removal from swh-model v5.0.0

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/674/ for more details.

Harbormaster completed remote builds in B25993: Diff 25123.Jan 13 2022, 11:53 AM

vlorentz requested review of this revision.Jan 13 2022, 11:53 AM

vlorentz added a child revision: D6938: tests: Replace 'offset' and 'negative_utc' with 'offset_bytes'.Jan 13 2022, 12:21 PM

vlorentz added a task: T3752: Store/represent time offsets as strings.Jan 13 2022, 12:26 PM

ardumont accepted this revision.Jan 13 2022, 12:39 PM

This revision is now accepted and ready to land.Jan 13 2022, 12:39 PM

Closed by commit rDLDBASEc2d96ed3e461: deposit: Remove 'negative_utc' from test data (authored by vlorentz). · Explain WhyJan 13 2022, 3:39 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDBASEc2d96ed3e461: deposit: Remove 'negative_utc' from test data.