Page MenuHomeSoftware Heritage
Differential D4013

Allow deposit metadata update on deposit already complete
ClosedPublic
Actions

Authored by ardumont on Sep 22 2020, 7:14 PM.

Details

Reviewers
vlorentz
moranegg
Group Reviewers
Reviewers
Maniphest Tasks
T2560: Extend **update** deposit endpoint to enable new/modified metadata from client on an existing deposit
Commits
rDDEPd1f3f69c9016: Allow deposit metadata update on deposit already completed
Summary

This allows the premise of the scenario [1] to occur.

Premise because the tids and bits about the metadata information to send to the
metadata storage is not completely clear. A first review from @moranegg and
@vlorentz to clarify that part would be nice.

[1] Update metadata for deposit whose archive and metadata are already stored
in the archive. Described in:
https://hackmd.io/yUZAp78KTdSvE4drf0_MqQ#2-Cas-d%E2%80%99utilisations-contributeur-HAL

Depends on D4057

Test Plan

tox

Diff Detail

Unit TestsFailed
View All

TimeTest
615 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_deposit_update::test_put_update_metadata_done_deposit_failure_empty_xml
tmp_path = '/tmp/pytest-of-jenkins/pytest-0/test_put_update_metadata_done_4' authenticated_client = <rest_framework.test.APIClient object at 0x7f91b64210f0> complete_deposit = <Deposit: {'id': 68, 'reception_date': datetime.datetime(2020, 9, 26, 16, 59, 48, 142728, tzinfo=<UTC>), 'collection': 'test', 'external_id': 'external-id-complete', 'client': 'test', 'status': 'done'}>
398 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_converters::test_convert_status_detail
300 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_converters::test_convert_status_detail_2
400 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_converters::test_convert_status_detail_3
395 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_converters::test_convert_status_detail_edge_case
View Full Test Results (1 Failed · 149 Passed)

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
moranegg added inline comments.Sep 25 2020, 10:53 AM
swh/deposit/api/deposit_update.py
229

I'm kinda surprised that HAL-preprod had the Malformed xml metadata error
I saw you opened a task to improve the error messages.
+1 on this in a separate diff.

275

an update of the metadata is only in the REMD, not in the storage, so no metadata on revisions.
But I'm not sure I understand the question.

277

The authority is the entity that gave the information.
In this case it's the client.

Let's check with @vlorentz how to format correctly the authority, because it shouldn't be just a string, but maybe it is.

ardumont marked 6 inline comments as done.Sep 25 2020, 10:56 AM
ardumont added inline comments.
swh/deposit/config.py
60

a priori irrelevant, so can go away.

ardumont added inline comments.Sep 25 2020, 11:06 AM
swh/deposit/api/deposit_update.py
275

ok, so here is the kicker ;)

Tthe loader deposit, when sending the metadata to the metadata storage, should attach those to the directory SWHID and not the revision like it is currently doing.

@vlorentz heads up ^

Question: Is the current metadata revision migration script already doing that change?

moranegg added inline comments.Sep 25 2020, 11:13 AM
swh/deposit/api/deposit_update.py
275

ooooh... now I get it.
With the content deposit, the metadata is sent to the loader to be added to the revision.

This is another big issue !! I didn't see coming, and I might need to check @vlorentz's script:
At the moment the metadata are on the revision because that's the place we had the metadata field.
But !!!
The content-deposit is a full tree with a snapshot, a revision, a directory. Metdata concerns all nodes of this tree.
The SWHID used in HAL is the directory SWHID, so most appropriate place is on the directory.

Maybe it should be on all nodes?

ardumont updated this revision to Diff 14265.EditedSep 25 2020, 11:37 AM
  • Add missing tests scenario (malformed xml, empty body request)
  • Fix corner case in empty existing scenario for empty request (which happens to be a possibility for the new scenario as well so it's fixed within the diff as well)
  • Drop wrong use of SWH_METADATA_AUTHORITY and send the metadata with the right metadata authority.
  • Clarify test docstrings and some comments

TODO:

  • runtime: Add functional checks on metadata received (same checks as what the checker does for the standard deposit scenario)
  • Tests: Checks the metadata written in the metadata storage are as expected
swh-public-ci added a comment.Sep 25 2020, 11:40 AM

Build is green

Patch application report for D4013 (id=14265)

Rebasing onto 047588a03f...

Current branch diff-target is up to date.
Changes applied before test
commit f94c9effa2437ae5fdfd5311361dfff20d4f0a83
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 22 19:15:19 2020 +0200

    Allow deposit metadata update on deposit already completed
    
    This will allow to update the metadata of a deposit in "done" state. The
    metadata update occurs both in the deposit backend and in the metadata
    storage (provided some basic checks pass).

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/118/ for more details.

Harbormaster completed remote builds in B15541: Diff 14265.Sep 25 2020, 11:40 AM
ardumont added a child revision: D4047: Add functional metadata checks prior to actually update metadata.Sep 25 2020, 1:31 PM
ardumont added a comment.Sep 25 2020, 1:36 PM

runtime: Add functional checks on metadata received (same checks as what the checker does for the standard deposit scenario)

D4047 (so the current diff does not grow too much)

swh/deposit/api/deposit_update.py
180

missing test for another diff.

ardumont mentioned this in D4047: Add functional metadata checks prior to actually update metadata.Sep 25 2020, 1:51 PM
ardumont added inline comments.Sep 25 2020, 2:03 PM
swh/deposit/tests/api/test_deposit_update.py
320

@moranegg empty body use case i kept talking about in D4047 ;)

ardumont mentioned this in D4048: test: Update missing scenario on update metadata with multipart (put).Sep 25 2020, 2:14 PM
ardumont added inline comments.Sep 25 2020, 2:14 PM
swh/deposit/api/deposit_update.py
180

D4048

ardumont retitled this revision from wip: Allow deposit metadata update on deposit already complete to Allow deposit metadata update on deposit already complete.Sep 25 2020, 3:25 PM
ardumont edited the test plan for this revision. (Show Details)
ardumont added inline comments.Sep 25 2020, 4:22 PM
swh/deposit/api/deposit_update.py
238

^ shouldn't it be about the deposit client (hal, ipol, etc...) here?

@vlorentz @moranegg ^

vlorentz requested changes to this revision.Sep 25 2020, 4:58 PM
vlorentz added inline comments.
swh/deposit/api/deposit_update.py
238

the provider is the deposit client

252–259

I'm not sure we should do that. It means we can't allow deposit updates while a storage is being replayed.

268

no, it should not replace, but add a new request.

swh/deposit/tests/api/test_deposit_update.py
146–147

it's not updated, it's added in both

154

you should check deposit.swh_id is a dir swhid, just to be sure there's no inconsistency

158–162

Remove this (see comment above)

169–170

move this at the top of the test (and also check there's a deposit request with the metadata)

185

2 (see comment above)

swh/deposit/tests/data/atom/entry-data-empty-body.xml
2

why this change?

This revision now requires changes to proceed.Sep 25 2020, 4:58 PM
ardumont added inline comments.Sep 25 2020, 5:06 PM
swh/deposit/api/deposit_update.py
252–259

i did not know the storage and storage metadata had the same requirements...
I'm using storage today to say storage-metadata, maybe that should change btw.

268

well, then it should be in another endpoint then, we are in the one that replaces stuff.

swh/deposit/tests/api/test_deposit_atom.py
58

That test was green for the wrong reason...

When debugging that test because i did not understand something, i saw the 400 failure was about the missing slug, not because of the empty body request.

I needed to have another equivalent test for the new endpoint.
So I fixed it here nonetheless.

@vlorentz tl; dr; that test failed without the .xml change you asked about.

swh/deposit/tests/data/atom/entry-data-empty-body.xml
2

because the tests was not correctly testing the empty body case.
I plan to have a follow up on that in another diff (but i forgot to mention it).

ardumont added inline comments.Sep 26 2020, 6:19 PM
swh/deposit/api/deposit_update.py
238

yes, thanks for confirming.

So that part is wrong, thanks.
There is no self.provider to use then...

268

we are in the put endpoint not post...
which I realize now is not the right place, thanks for spotting it.

swh/deposit/tests/api/test_deposit_update.py
146–147

yes, i used the wrong endpoint, should be in the other iri that allows adding new metadata to be added.
Will change that on monday.

Thanks!

ardumont added inline comments.Sep 26 2020, 6:57 PM
swh/deposit/tests/data/atom/entry-data-empty-body.xml
2

I'm removing it from that diff as it's arguably not its place.

That's D4057 now which this diff will depend on (because it uses the same empty file to check something similar from another endpoint though).

ardumont updated this revision to Diff 14313.Sep 26 2020, 6:57 PM

Rebase on D4057

ardumont edited the summary of this revision. (Show Details)Sep 26 2020, 6:57 PM
ardumont added a parent revision: D4057: Fix deposit atom test to actually check the response message.
swh-public-ci added a comment.Sep 26 2020, 7:00 PM

Build has FAILED

Patch application report for D4013 (id=14313)

Could not rebase; Attempt merge onto b820c61d67...

Merge made by the 'recursive' strategy.
 swh/deposit/__init__.py                            |  11 +
 swh/deposit/api/__init__.py                        |   7 -
 swh/deposit/api/common.py                          |  38 ++-
 swh/deposit/api/deposit_update.py                  | 220 +++++++++++--
 swh/deposit/api/private/deposit_read.py            |  10 -
 swh/deposit/config.py                              |   7 +
 .../api/test_deposit_private_read_metadata.py      |   2 +-
 swh/deposit/tests/api/test_deposit_update.py       | 362 ++++++++++++++++++++-
 swh/deposit/tests/conftest.py                      |  24 +-
 swh/deposit/tests/test_init.py                     |   2 +-
 10 files changed, 609 insertions(+), 74 deletions(-)
Changes applied before test
commit f7613cb430b6e73e7f8e9cdd0b0787719ce65e34
Merge: b820c61d e66a4a77
Author: Jenkins user <jenkins@localhost>
Date:   Sat Sep 26 16:57:58 2020 +0000

    Merge branch 'diff-target' into HEAD

commit e66a4a77e77b4a1a4cb2d9f6820a6f131eb1c7d9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 22 19:15:19 2020 +0200

    Allow deposit metadata update on deposit already completed
    
    This will allow to update the metadata of a deposit in "done" state. The
    metadata update occurs both in the deposit backend and in the metadata
    storage (provided some basic checks pass).

commit 7271e750bca43692fb88b4fbd9126e88462460ac
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Sep 26 18:37:50 2020 +0200

    Fix deposit atom test to actually check the response message
    
    Prior to this commit, the actual test was wrongfully ok because the slug was
    missing. This resulted in a 400 response which passed because we missed
    checking the actual response content. This now fixes it.

commit bb0167a8945c12a22e8d63e42b291dc414b59525
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 25 15:15:37 2020 +0200

    Fix transition deposit to deposited state with empty post on SE IRI
    
    Prior to this the content-length could be None instead of 0, failing the
    transition.
    
    As the coverage was missing, that peculiar case was missed. This fixes it.

commit c6debbd53a1c055be30abbf738fb81aed382da49
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 25 14:28:10 2020 +0200

    test: Update missing scenario on update metadata with multipart (post)

commit 8c40c1e093913734549590a5893d4d610e331de3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 25 14:14:20 2020 +0200

    test: Update missing scenario on update metadata with multipart (put)

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/134/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/134/console

Harbormaster failed remote builds in B15611: Diff 14313!Sep 26 2020, 7:00 PM
ardumont planned changes to this revision.Sep 26 2020, 7:03 PM
ardumont updated this revision to Diff 14314.Sep 26 2020, 7:05 PM

Fix test

swh-public-ci added a comment.Sep 26 2020, 7:07 PM

Build is green

Patch application report for D4013 (id=14314)

Could not rebase; Attempt merge onto b820c61d67...

Merge made by the 'recursive' strategy.
 swh/deposit/__init__.py                            |  11 +
 swh/deposit/api/__init__.py                        |   7 -
 swh/deposit/api/common.py                          |  38 ++-
 swh/deposit/api/deposit_update.py                  | 220 +++++++++++--
 swh/deposit/api/private/deposit_read.py            |  10 -
 swh/deposit/config.py                              |   7 +
 .../api/test_deposit_private_read_metadata.py      |   2 +-
 swh/deposit/tests/api/test_deposit_update.py       | 362 ++++++++++++++++++++-
 swh/deposit/tests/conftest.py                      |  24 +-
 .../tests/data/atom/entry-data-empty-body.xml      |   2 +-
 swh/deposit/tests/test_init.py                     |   2 +-
 11 files changed, 610 insertions(+), 75 deletions(-)
Changes applied before test
commit e7e5a24e64de82bca972db3c7c88e9714d97ca72
Merge: b820c61d 96ada866
Author: Jenkins user <jenkins@localhost>
Date:   Sat Sep 26 17:05:29 2020 +0000

    Merge branch 'diff-target' into HEAD

commit 96ada86633e473064904bab7ed1ea7168a965fe2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 22 19:15:19 2020 +0200

    Allow deposit metadata update on deposit already completed
    
    This will allow to update the metadata of a deposit in "done" state. The
    metadata update occurs both in the deposit backend and in the metadata
    storage (provided some basic checks pass).

commit 7271e750bca43692fb88b4fbd9126e88462460ac
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Sep 26 18:37:50 2020 +0200

    Fix deposit atom test to actually check the response message
    
    Prior to this commit, the actual test was wrongfully ok because the slug was
    missing. This resulted in a 400 response which passed because we missed
    checking the actual response content. This now fixes it.

commit bb0167a8945c12a22e8d63e42b291dc414b59525
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 25 15:15:37 2020 +0200

    Fix transition deposit to deposited state with empty post on SE IRI
    
    Prior to this the content-length could be None instead of 0, failing the
    transition.
    
    As the coverage was missing, that peculiar case was missed. This fixes it.

commit c6debbd53a1c055be30abbf738fb81aed382da49
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 25 14:28:10 2020 +0200

    test: Update missing scenario on update metadata with multipart (post)

commit 8c40c1e093913734549590a5893d4d610e331de3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 25 14:14:20 2020 +0200

    test: Update missing scenario on update metadata with multipart (put)

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/135/ for more details.

Harbormaster completed remote builds in B15612: Diff 14314.Sep 26 2020, 7:08 PM
ardumont updated this revision to Diff 14320.Sep 26 2020, 7:10 PM

Rebase

swh-public-ci added a comment.Sep 26 2020, 7:22 PM

Build is green

Patch application report for D4013 (id=14320)

Could not rebase; Attempt merge onto b820c61d67...

Updating b820c61d..221e4155
Fast-forward
 swh/deposit/__init__.py                            |  11 +
 swh/deposit/api/__init__.py                        |   7 -
 swh/deposit/api/common.py                          |  38 ++-
 swh/deposit/api/deposit_update.py                  | 220 +++++++++++--
 swh/deposit/api/private/deposit_read.py            |  10 -
 swh/deposit/config.py                              |   7 +
 .../api/test_deposit_private_read_metadata.py      |   2 +-
 swh/deposit/tests/api/test_deposit_update.py       | 362 ++++++++++++++++++++-
 swh/deposit/tests/conftest.py                      |  24 +-
 .../tests/data/atom/entry-data-empty-body.xml      |   2 +-
 swh/deposit/tests/test_init.py                     |   2 +-
 11 files changed, 610 insertions(+), 75 deletions(-)
Changes applied before test
commit 221e415573d1356049103eff26152076d9f23d1a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 22 19:15:19 2020 +0200

    Allow deposit metadata update on deposit already completed
    
    This will allow to update the metadata of a deposit in "done" state. The
    metadata update occurs both in the deposit backend and in the metadata
    storage (provided some basic checks pass).

commit 45c7c35e471ce28529bc495a076d10e2c67b9cf7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Sep 26 18:37:50 2020 +0200

    Fix deposit atom test to actually check the response message
    
    Prior to this commit, the actual test was wrongfully ok because the slug was
    missing. This resulted in a 400 response which passed because we missed
    checking the actual response content. This now fixes it.

commit b04c457d65689ae5e278edac7faee34bb3a2908f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 25 15:15:37 2020 +0200

    Fix transition deposit to deposited state with empty post on SE IRI
    
    Prior to this the content-length could be None instead of 0, failing the
    transition.
    
    As the coverage was missing, that peculiar case was missed. This fixes it.

commit f26ea4492695238164e8ac1bcec984feed68ed9d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 25 14:28:10 2020 +0200

    test: Update missing scenario on update metadata with multipart (post)

commit 251a0031eada21011d1683e6d755c1813830b97b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 25 14:14:20 2020 +0200

    test: Update missing scenario on update metadata with multipart (put)

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/141/ for more details.

Harbormaster completed remote builds in B15618: Diff 14320.Sep 26 2020, 7:22 PM
ardumont updated this revision to Diff 14324.EditedSep 27 2020, 11:48 AM

Adapt according to remaining unadapted suggestions (and more):

  • Actually add new metadata information during update instead of replacing those (technically also move the code from the PUT to the POST method part)
  • Update docstrings accordingly
  • Rename storage attribute to storage_metadata
  • Drop self.provider setup to actually reference the deposit client as the provider (and adapt the other part already using it)
  • Send raw metadata into the metadata storage (instead of the parsed json one)

Remaining part is to actually check the metadata format stored (I'll do that in another diff so we can focus the discussion on that if need be). That diff is now way too long due to the discussions...

swh-public-ci added a comment.Sep 27 2020, 11:51 AM

Build is green

Patch application report for D4013 (id=14324)

Could not rebase; Attempt merge onto f26ea44926...

Updating f26ea449..f23ad6cb
Fast-forward
 swh/deposit/__init__.py                            |  11 +
 swh/deposit/api/__init__.py                        |   7 -
 swh/deposit/api/common.py                          |  38 ++--
 swh/deposit/api/deposit_update.py                  | 221 +++++++++++++++++--
 swh/deposit/api/private/deposit_read.py            |  23 +-
 swh/deposit/config.py                              |   6 +
 .../api/test_deposit_private_read_metadata.py      |   2 +-
 swh/deposit/tests/api/test_deposit_update.py       | 236 ++++++++++++++++++++-
 swh/deposit/tests/conftest.py                      |  30 +--
 .../tests/data/atom/entry-data-empty-body.xml      |   2 +-
 swh/deposit/tests/test_init.py                     |   2 +-
 11 files changed, 500 insertions(+), 78 deletions(-)
Changes applied before test
commit f23ad6cb2a550d94b0a81b1d718f24256acb94e7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 22 19:15:19 2020 +0200

    Allow deposit metadata update on deposit already completed
    
    This will allow to update the metadata of a deposit in "done" state. The
    metadata update occurs both in the deposit backend and in the metadata
    storage (provided some basic checks pass).

commit 45c7c35e471ce28529bc495a076d10e2c67b9cf7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Sep 26 18:37:50 2020 +0200

    Fix deposit atom test to actually check the response message
    
    Prior to this commit, the actual test was wrongfully ok because the slug was
    missing. This resulted in a 400 response which passed because we missed
    checking the actual response content. This now fixes it.

commit b04c457d65689ae5e278edac7faee34bb3a2908f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 25 15:15:37 2020 +0200

    Fix transition deposit to deposited state with empty post on SE IRI
    
    Prior to this the content-length could be None instead of 0, failing the
    transition.
    
    As the coverage was missing, that peculiar case was missed. This fixes it.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/143/ for more details.

Harbormaster completed remote builds in B15622: Diff 14324.Sep 27 2020, 11:51 AM
ardumont added a comment.EditedSep 27 2020, 12:03 PM

@moranegg @vlorentz heads up (for tomorrow), I should have adressed all concerns now ;)

Like i said in the update diff message, there remains the check on the actual metadata stored (FIXME for now).
I'd like to dedicate to this in another iteration (diff) though.
So the eventual discussion on that can happen there.

This current diff is way too long now (due to the good discussions we had).

Cheers,

ardumont mentioned this in D4058: Check updated metadata are correctly stored in the metadata storage.Sep 27 2020, 3:39 PM
ardumont added a comment.Sep 27 2020, 5:12 PM

Like i said in the update diff message, there remains the check on the actual metadata stored (FIXME for now).
I'd like to dedicate to this in another iteration (diff) though.
So the eventual discussion on that can happen there.

D4058

vlorentz added a comment.Sep 28 2020, 12:03 PM

as discussed on side-channels, it should be a PUT

vlorentz requested changes to this revision.Sep 28 2020, 12:03 PM
This revision now requires changes to proceed.Sep 28 2020, 12:03 PM
ardumont updated this revision to Diff 14329.Sep 28 2020, 1:07 PM

Use the PUT endpoint

swh-public-ci added a comment.Sep 28 2020, 1:10 PM

Build is green

Patch application report for D4013 (id=14329)

Rebasing onto 45c7c35e47...

Current branch diff-target is up to date.
Changes applied before test
commit d1f3f69c9016ad6bb7d49515fc187dd1c85039eb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 22 19:15:19 2020 +0200

    Allow deposit metadata update on deposit already completed
    
    This will allow to update the metadata of a deposit in "done" state. The
    metadata update occurs both in the deposit backend and in the metadata
    storage (provided some basic checks pass).

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/146/ for more details.

Harbormaster completed remote builds in B15627: Diff 14329.Sep 28 2020, 1:10 PM
vlorentz accepted this revision.Sep 28 2020, 1:14 PM

Let's not forget to remove the directory_missing check later

This revision is now accepted and ready to land.Sep 28 2020, 1:14 PM
Closed by commit rDDEPd1f3f69c9016: Allow deposit metadata update on deposit already completed (authored by ardumont). · Explain WhySep 28 2020, 1:16 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDDEPd1f3f69c9016: Allow deposit metadata update on deposit already completed.
ardumont mentioned this in D4059: deposit_update: Drop the unneeded check on the directory_missing call.Sep 28 2020, 1:19 PM
ardumont added inline comments.Sep 28 2020, 4:20 PM
swh/deposit/tests/data/atom/entry-data-empty-body.xml
2

because the tests was not correctly testing the empty body case.
I plan to have a follow up on that in another diff (but i forgot to mention it).

D4067 ;)

ardumont mentioned this in D4067: tests: Ensure all empty body test cases are covered.Sep 28 2020, 4:20 PM
ardumont added a task: T2560: Extend **update** deposit endpoint to enable new/modified metadata from client on an existing deposit.Sep 30 2020, 12:25 PM
ardumont mentioned this in D4105: deposit: Adapt loader to send extrinsic raw metadata to the metadata storage.Sep 30 2020, 6:44 PM
vlorentz mentioned this in D4161: conf/deposit: Update deposit configuration.Oct 7 2020, 9:23 AM

Revision Contents
Changeset List

PathSize
swh/
deposit/
11 lines
api/
7 lines
38 lines
182 lines
private/
10 lines
7 lines
tests/
api/
2 lines
2 lines
191 lines
24 lines
data/
atom/
2 lines
2 lines

Diff 14313

View Options

swh/deposit/__init__.py

Loading...
View Options

swh/deposit/api/__init__.py

Loading...
View Options

swh/deposit/api/common.py

Loading...
View Options

swh/deposit/api/deposit_update.py

Loading...
View Options

swh/deposit/api/private/deposit_read.py

Loading...
View Options

swh/deposit/config.py

Loading...
View Options

swh/deposit/tests/api/test_deposit_atom.py

Loading...
View Options

swh/deposit/tests/api/test_deposit_private_read_metadata.py

Loading...
View Options

swh/deposit/tests/api/test_deposit_update.py

Loading...
View Options

swh/deposit/tests/conftest.py

Loading...
View Options

swh/deposit/tests/data/atom/entry-data-empty-body.xml

Loading...
View Options

swh/deposit/tests/test_init.py

Loading...
About · Developer information · Legal