Page MenuHomeSoftware Heritage

assets,templates: Add missing origin URL query parameters encoding
ClosedPublic

Authored by anlambert on Fri, Sep 11, 6:07 PM.

Details

Summary

Some origin URLs might contain characters that need to be escaped when
setting an origin URL to a query parameter.

So ensure to properly encode them to avoid 404 errors.

Closes T2584

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Fri, Sep 11, 6:07 PM

Build is green

Patch application report for D3934 (id=13862)

Rebasing onto 8545e0a445...

Current branch diff-target is up to date.
Changes applied before test
commit c2033769a5161a0a518b8d4ad39ce78f879a3c3c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Sep 11 18:01:58 2020 +0200

    assets,templates: Add missing origin URL query parameters encoding
    
    Some origin URLs might contain characters that need to be escaped when
    setting an origin URL to a query parameter.
    
    So ensure to properly encode them to avoid 404 errors.
    
    Closes T2584

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/359/ for more details.

vlorentz requested changes to this revision.Mon, Sep 14, 9:06 AM
vlorentz added a subscriber: vlorentz.

Can you add tests?

This revision now requires changes to proceed.Mon, Sep 14, 9:06 AM
vlorentz accepted this revision.Mon, Sep 14, 9:39 AM

uh nevermind, there are already

This revision is now accepted and ready to land.Mon, Sep 14, 9:39 AM