Maniphest T2584

Wrong link for repositories with '+' in the url
Closed, MigratedEdits Locked
Actions

Assigned To

gitlab-migration

Authored By

	vsellier
	Sep 11 2020, 10:51 AM

Tags

Subscribers

gitlab-migration

Description

Some repositories have '+' on the url.
After a search like this one libstdc++: https://archive.softwareheritage.org/browse/search/?q=libstdc%2B%2B&with_visit=true&with_content=true
The proposed links send the user on page returning a 404 error : https://archive.softwareheritage.org/browse/origin/directory/?origin_url=http://snapshot.debian.org/package/libstdc%20%20-arm-none-eabi/

If the %20 are replaced with %2B, the repo is found:
https://archive.softwareheritage.org/browse/origin/directory/?origin_url=http://snapshot.debian.org/package/libstdc%2B%2B-arm-none-eabi/

Revisions and Commits

rDWAPPS Web applications
	D3934	rDWAPPSc2033769a516 assets,templates: Add missing origin URL query parameters encoding

Related Objects

Mentioned In: T2577: Test gitea lister on staging environment

Event Timeline

vsellier triaged this task as Normal priority.Sep 11 2020, 10:51 AM

vsellier created this task.

Nice catch, URI components should indeed be encoded. I will fix that asap.

anlambert added a revision: D3934: assets,templates: Add missing origin URL query parameters encoding.Sep 11 2020, 6:07 PM

ardumont mentioned this in T2577: Test gitea lister on staging environment.Sep 14 2020, 10:44 AM

anlambert closed this task as Resolved by committing rDWAPPSc2033769a516: assets,templates: Add missing origin URL query parameters encoding.Sep 14 2020, 12:40 PM

anlambert claimed this task.

anlambert added a commit: rDWAPPSc2033769a516: assets,templates: Add missing origin URL query parameters encoding.

This task has been migrated to GitLab.