Differential D3934

assets,templates: Add missing origin URL query parameters encoding
ClosedPublic
Actions

Authored by anlambert on Sep 11 2020, 6:07 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2584: Wrong link for repositories with '+' in the url

Commits

rDWAPPSc2033769a516: assets,templates: Add missing origin URL query parameters encoding

Summary

Some origin URLs might contain characters that need to be escaped when
setting an origin URL to a query parameter.

So ensure to properly encode them to avoid 404 errors.

Closes T2584

Diff Detail

Repository

rDWAPPS Web applications

Branch

origin-url-encode

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15086
Build 23259: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 23258: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 11 2020, 6:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 11 2020, 6:07 PM

Build is green

Patch application report for D3934 (id=13862)

Rebasing onto 8545e0a445...

Current branch diff-target is up to date.

Changes applied before test

commit c2033769a5161a0a518b8d4ad39ce78f879a3c3c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Sep 11 18:01:58 2020 +0200

    assets,templates: Add missing origin URL query parameters encoding
    
    Some origin URLs might contain characters that need to be escaped when
    setting an origin URL to a query parameter.
    
    So ensure to properly encode them to avoid 404 errors.
    
    Closes T2584

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/359/ for more details.

Harbormaster completed remote builds in B15086: Diff 13862.Sep 11 2020, 6:13 PM