Page MenuHomeSoftware Heritage
Differential D1146

cli: add a --runs option to 'swh-scheduler task list' tool
ClosedPublic
Actions

Authored by douardda on Feb 15 2019, 5:11 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDSCH058f12001ebf: cli: add a --runs option to 'swh-scheduler task list' tool
Summary

this options allws to list task runs for selected tasks.

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
master
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 4269
Build 5639: tox-on-jenkinsJenkins
Build 5638: arc lint + arc unit

Event Timeline

douardda created this revision.Feb 15 2019, 5:11 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 15 2019, 5:11 PM
Harbormaster failed remote builds in B4269: Diff 3617!Feb 15 2019, 5:15 PM
swh-public-ci added a subscriber: swh-public-ci.Feb 15 2019, 5:15 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/179/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/179/console

vlorentz requested changes to this revision.Feb 15 2019, 6:06 PM
vlorentz added a subscriber: vlorentz.

The new API endpoints don't have tests.

(And we should probably write tests for the CLI at some point, it's getting complex.)

swh/scheduler/backend.py
464–467

duplicate (it's funny that flake8 didn't catch this)

477

Why a dict?

487–488

Rename to get_task_runs_from_backend?

490–493

same

503

same

swh/scheduler/cli.py
341–342

help='Also list past executions of each task.'

373–376

I'm not a huge fan of using the name run both for the boolean option and for storing the dictionary.

This revision now requires changes to proceed.Feb 15 2019, 6:06 PM
vlorentz added inline comments.Feb 15 2019, 6:06 PM
swh/scheduler/cli.py
373–376

runs *

douardda marked 3 inline comments as done.Feb 19 2019, 9:55 AM
douardda added inline comments.
swh/scheduler/backend.py
464–467

yep, it's weird...

477

indeed, should be an empty list/tuple here. thx

swh/scheduler/cli.py
373–376

I generally agree with that, but in some cases (like here), I see no real harm in doing so. The boolean value of runs remains valid all the way along, and finding a variable name is way too hard :-)

ardumont added subscribers: zack, ardumont.Feb 19 2019, 11:31 AM

(And we should probably write tests for the CLI at some point, it's getting complex.)

IIRC, @zack added some to swh.model.cli
That might be a starting point.

douardda updated this revision to Diff 3637.Feb 20 2019, 10:22 AM

add tests... and consequently fix the client part of the new backend method

douardda updated this revision to Diff 3640.Feb 20 2019, 10:24 AM

rebase

vlorentz accepted this revision.Feb 20 2019, 10:28 AM
This revision is now accepted and ready to land.Feb 20 2019, 10:28 AM
swh-public-ci added a comment.Feb 20 2019, 10:29 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/184/ for more details.

Harbormaster completed remote builds in B4314: Diff 3637.Feb 20 2019, 10:29 AM
Harbormaster completed remote builds in B4317: Diff 3640.Feb 20 2019, 10:33 AM
swh-public-ci added a comment.Feb 20 2019, 10:33 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/187/ for more details.

Closed by commit rDSCH058f12001ebf: cli: add a --runs option to 'swh-scheduler task list' tool (authored by douardda). · Explain WhyFeb 20 2019, 11:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
scheduler/
api/
3 lines
7 lines
53 lines
34 lines

Diff 3617

View Options

swh/scheduler/api/client.py

Loading...
View Options

swh/scheduler/api/server.py

Loading...
View Options

swh/scheduler/backend.py

Loading...
View Options

swh/scheduler/cli.py

Loading...
About · Developer information · Legal