this options allws to list task runs for selected tasks.
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDSCH058f12001ebf: cli: add a --runs option to 'swh-scheduler task list' tool
Diff Detail
- Repository
- rDSCH Scheduling utilities
- Branch
- master
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 4314 Build 5697: tox-on-jenkins Jenkins Build 5696: arc lint + arc unit
Event Timeline
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/179/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/179/console
The new API endpoints don't have tests.
(And we should probably write tests for the CLI at some point, it's getting complex.)
swh/scheduler/backend.py | ||
---|---|---|
463–466 | duplicate (it's funny that flake8 didn't catch this) | |
476 | Why a dict? | |
486–487 | Rename to get_task_runs_from_backend? | |
489–492 | same | |
502 | same | |
swh/scheduler/cli.py | ||
340–341 | help='Also list past executions of each task.' | |
372–375 | I'm not a huge fan of using the name run both for the boolean option and for storing the dictionary. |
swh/scheduler/cli.py | ||
---|---|---|
372–375 | runs * |
swh/scheduler/backend.py | ||
---|---|---|
463–466 | yep, it's weird... | |
476 | indeed, should be an empty list/tuple here. thx | |
swh/scheduler/cli.py | ||
372–375 | I generally agree with that, but in some cases (like here), I see no real harm in doing so. The boolean value of runs remains valid all the way along, and finding a variable name is way too hard :-) |
(And we should probably write tests for the CLI at some point, it's getting complex.)
IIRC, @zack added some to swh.model.cli
That might be a starting point.
Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/184/ for more details.
Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/187/ for more details.