Paths

Table of Contentst

Differential D1146

cli: add a --runs option to 'swh-scheduler task list' tool
ClosedPublic
Actions

Authored by douardda on Feb 15 2019, 5:11 PM.

Details

Reviewers

Group Reviewers

Commits

rDSCH058f12001ebf: cli: add a --runs option to 'swh-scheduler task list' tool

Summary

this options allws to list task runs for selected tasks.

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Feb 15 2019, 5:11 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 15 2019, 5:11 PM

Harbormaster failed remote builds in B4269: Diff 3617!Feb 15 2019, 5:15 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/179/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/179/console

The new API endpoints don't have tests.

(And we should probably write tests for the CLI at some point, it's getting complex.)

swh/scheduler/backend.py
463–466	duplicate (it's funny that `flake8` didn't catch this)
476	Why a dict?
486–487	Rename to `get_task_runs_from_backend`?
489–492	same
502	same
swh/scheduler/cli.py
340–341	`help='Also list past executions of each task.'`
372–375	I'm not a huge fan of using the name `run` both for the boolean option and for storing the dictionary.

This revision now requires changes to proceed.Feb 15 2019, 6:06 PM

vlorentz added inline comments.Feb 15 2019, 6:06 PM

swh/scheduler/cli.py
372–375	`runs` *

douardda marked 3 inline comments as done.Feb 19 2019, 9:55 AM

douardda added inline comments.

swh/scheduler/backend.py
463–466	yep, it's weird...
476	indeed, should be an empty list/tuple here. thx
swh/scheduler/cli.py
372–375	I generally agree with that, but in some cases (like here), I see no real harm in doing so. The boolean value of `runs` remains valid all the way along, and finding a variable name is way too hard :-)

(And we should probably write tests for the CLI at some point, it's getting complex.)

IIRC, @zack added some to swh.model.cli
That might be a starting point.

add tests... and consequently fix the client part of the new backend method

rebase

vlorentz accepted this revision.Feb 20 2019, 10:28 AM

This revision is now accepted and ready to land.Feb 20 2019, 10:28 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/184/ for more details.

Harbormaster completed remote builds in B4314: Diff 3637.Feb 20 2019, 10:29 AM

Harbormaster completed remote builds in B4317: Diff 3640.Feb 20 2019, 10:33 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/187/ for more details.

Closed by commit rDSCH058f12001ebf: cli: add a --runs option to 'swh-scheduler task list' tool (authored by douardda). · Explain WhyFeb 20 2019, 11:31 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

scheduler/

api/

4 lines

7 lines

26 lines

36 lines

tests/

test_scheduler.py

141 lines

Diff 3651

swh/scheduler/api/client.py

Loading...

swh/scheduler/api/server.py

Loading...

swh/scheduler/backend.py

Loading...

swh/scheduler/cli.py

Loading...

swh/scheduler/tests/test_scheduler.py

Loading...