Paths

Table of Contentst

Differential D1035

Make the prepare_event helper function pre-aggregate the events with same url
ClosedPublic
Actions

Authored by douardda on Jan 30 2019, 10:58 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSCH4fc7a8917878: Make the prepare_event helper function pre-aggregate the events with same url

Summary

and strip these urls as well.

It makes no sense to register 2 different URLs when they are equal to a
trailing ws detail.
As a result, we must preaggregate them because the swh_cache_put() sql
function won't allow several 'on conflict' for the same id.

Rewrite updater/test_backend.py with pytest and use the postgresql fixture

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 3847
Build 5039: tox-on-jenkins	Jenkins
Build 5038: arc lint + arc unit

Event Timeline

douardda created this revision.Jan 30 2019, 10:58 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 30 2019, 10:58 AM

douardda added a parent revision: D1034: Kill DbBackend class.Jan 30 2019, 10:59 AM

Harbormaster failed remote builds in B3840: Diff 3284!Jan 30 2019, 10:59 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/136/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/136/console

Thank you!

swh/scheduler/updater/backend.py
61	`not mean`

This revision is now accepted and ready to land.Jan 30 2019, 11:03 AM

fix the typo in the docstring

Harbormaster failed remote builds in B3847: Diff 3286!Jan 30 2019, 11:53 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/138/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/138/console

Closed by commit rDSCH4fc7a8917878: Make the prepare_event helper function pre-aggregate the events with same url (authored by douardda). · Explain WhyJan 30 2019, 11:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

scheduler/

updater/

backend.py

38 lines

Diff 3286

View Options

swh/scheduler/updater/backend.py

Make the prepare_event helper function pre-aggregate the events with same urlClosedPublicActions