Differential D1034

Kill DbBackend class
ClosedPublic
Actions

Authored by douardda on Jan 30 2019, 10:57 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSCHebee014ab868: Kill DbBackend class

Summary

we can now use directly the implementation of the copy_to() method from
swh.core's BaseDb, so we just have to extract the format_query as a simple
function (which it should have been since the beginning).

Adapt updater/backend.py acordingly.

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 30 2019, 10:57 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 30 2019, 10:57 AM

Harbormaster failed remote builds in B3839: Diff 3283!Jan 30 2019, 10:58 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/135/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/135/console

douardda added a child revision: D1035: Make the prepare_event helper function pre-aggregate the events with same url.Jan 30 2019, 10:59 AM

douardda added a parent revision: D1028: Refactor swh/scheduler/updater as well.

ardumont accepted this revision.Jan 30 2019, 11:01 AM

This revision is now accepted and ready to land.Jan 30 2019, 11:01 AM

Closed by commit rDSCHebee014ab868: Kill DbBackend class (authored by douardda). · Explain WhyJan 30 2019, 11:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

scheduler/

backend.py

90 lines

updater/

backend.py

16 lines

Diff 3290

View Options

swh/scheduler/backend.py