Page MenuHomeSoftware Heritage

Add support for content-negotiation in the API
ClosedPublic

Authored by douardda on Tue, Jan 29, 3:01 PM.

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Tue, Jan 29, 3:01 PM
vlorentz accepted this revision.Tue, Jan 29, 4:52 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/scheduler/api/server.py
46–49

Can be rewritten as:

def has_no_empty_params(rule):
    return len(rule.defaults or ()) >= len(rule.arguments or ())
172–184

What is this new endpoint for?

This revision is now accepted and ready to land.Tue, Jan 29, 4:52 PM
vlorentz requested changes to this revision.Tue, Jan 29, 4:53 PM
vlorentz added inline comments.
swh/scheduler/api/server.py
172–184

And it lacks a test.

This revision now requires changes to proceed.Tue, Jan 29, 4:53 PM
douardda updated this revision to Diff 3279.Wed, Jan 30, 10:49 AM
douardda marked 3 inline comments as done.

Extract the /site-map endpoint in a dedicated diff

sorry part of this diff has been mistakenly push as 94258bda1846

vlorentz accepted this revision.Wed, Jan 30, 11:48 AM
This revision is now accepted and ready to land.Wed, Jan 30, 11:48 AM
This revision was automatically updated to reflect the committed changes.