Page MenuHomeSoftware Heritage

Fix tests for the scheduler and the API
ClosedPublic

Authored by douardda on Jan 29 2019, 3:10 PM.

Details

Summary

adapt the configuration to latest refactorings (especially the 'scheduling_db'
config entry which is now just 'db').

Also refactor the scheduler tests to simplify the test class a bit: constants
used in the test do not need to be in the setUp of the test class, making this
setUp method useless.

Doing so, ensure to use simple dicts as test constants instead of
copy-the-modify them. This is (unit)test file, the dumbest, the better.

Depends on D1026

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 29 2019, 3:10 PM
vlorentz accepted this revision.Jan 29 2019, 5:09 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/scheduler/tests/test_scheduler.py
70

Any idea why needed that?

This revision is now accepted and ready to land.Jan 29 2019, 5:09 PM
douardda marked an inline comment as done.Jan 30 2019, 10:52 AM
douardda added inline comments.
swh/scheduler/tests/test_scheduler.py
70

nope

This revision was automatically updated to reflect the committed changes.