Page MenuHomeSoftware Heritage

tenma (Tenma)
User

Projects

User Details

User Since
Sep 2 2020, 11:39 AM (186 w, 1 d)

Recent Activity

Feb 12 2021

tenma added a reviewer for D5069: docs: Add new "howto write a lister tutorial" with unified lister api: Reviewers.
Feb 12 2021, 5:28 PM · Documentation, Lister
tenma retitled D5069: docs: Add new "howto write a lister tutorial" with unified lister api from Write the new lister tutorial for latest API to New lister tutorial for latest API.
Feb 12 2021, 5:10 PM · Documentation, Lister
tenma requested review of D5069: docs: Add new "howto write a lister tutorial" with unified lister api.
Feb 12 2021, 12:10 PM · Documentation, Lister

Feb 11 2021

tenma closed D5044: Add a guide on software testing.
Feb 11 2021, 5:34 PM · Documentation
tenma committed rDDOC87dbf6a29a49: Add a guide on software testing (authored by tenma).
Add a guide on software testing
Feb 11 2021, 5:34 PM
tenma updated the diff for D5044: Add a guide on software testing.

Rebase

Feb 11 2021, 5:33 PM · Documentation
tenma closed D5022: Add a tutorial on debugging and monitoring issues.
Feb 11 2021, 5:32 PM · Documentation
tenma committed rDDOC49d06700b32a: Add a guide on debugging and monitoring issues (authored by tenma).
Add a guide on debugging and monitoring issues
Feb 11 2021, 5:32 PM

Feb 10 2021

tenma updated the diff for D4731: WIP Configuration system.

Minor phrasing fixes

Feb 10 2021, 11:48 AM · feedback-required, Core & foundations

Feb 9 2021

tenma updated the diff for D5044: Add a guide on software testing.

Update based on @vlorentz remarks

Feb 9 2021, 2:37 PM · Documentation
tenma added inline comments to D5044: Add a guide on software testing.
Feb 9 2021, 2:31 PM · Documentation
tenma updated the diff for D4731: WIP Configuration system.
  • config.spec: Submit first draft
  • config.spec: Adress remarks from @ardumont, @vlorentz
  • config.spec: Address remarks from @douardda
  • config.spec: Rename "singleton" to "record"
  • config.spec: Address @ardumont remarks, strip down some sections
Feb 9 2021, 12:30 PM · feedback-required, Core & foundations
tenma updated the diff for D4927: lister.docs: add a lister template for the new API.

Small docstring fix

Feb 9 2021, 11:32 AM · Sprint 2021 01, Lister
tenma updated the diff for D5022: Add a tutorial on debugging and monitoring issues.

Change title, it is more a guide than a tutorial IMO

Feb 9 2021, 11:02 AM · Documentation
tenma updated the diff for D5044: Add a guide on software testing.

Add the doc to the documentation index

Feb 9 2021, 10:58 AM · Documentation
tenma updated the diff for D5022: Add a tutorial on debugging and monitoring issues.

Adressed other remarks from @moranegg

Feb 9 2021, 10:43 AM · Documentation
tenma added a reviewer for D5044: Add a guide on software testing: moranegg.
Feb 9 2021, 10:12 AM · Documentation
tenma requested review of D5044: Add a guide on software testing.
Feb 9 2021, 10:11 AM · Documentation

Feb 5 2021

tenma updated the diff for D5022: Add a tutorial on debugging and monitoring issues.

Adressed parts of the remarks from @moranegg

Feb 5 2021, 5:43 PM · Documentation
tenma updated the diff for D5022: Add a tutorial on debugging and monitoring issues.

Address remarks.
Improve URL formatting.

Feb 5 2021, 4:09 PM · Documentation
tenma added inline comments to D4927: lister.docs: add a lister template for the new API.
Feb 5 2021, 10:32 AM · Sprint 2021 01, Lister
tenma updated the diff for D5022: Add a tutorial on debugging and monitoring issues.

Improved the Sentry debugging section

Feb 5 2021, 10:29 AM · Documentation
tenma updated the summary of D5022: Add a tutorial on debugging and monitoring issues.
Feb 5 2021, 10:08 AM · Documentation
tenma added a reviewer for D5022: Add a tutorial on debugging and monitoring issues: moranegg.
Feb 5 2021, 10:06 AM · Documentation
tenma requested review of D5022: Add a tutorial on debugging and monitoring issues.
Feb 5 2021, 10:05 AM · Documentation

Feb 3 2021

tenma updated the summary of D4766: [WIP] git bare revision cooker.
Feb 3 2021, 12:34 PM · Vault
tenma updated the summary of D4766: [WIP] git bare revision cooker.
Feb 3 2021, 12:34 PM · Vault
tenma retitled D4766: [WIP] git bare revision cooker from WIP git bare revision cooker to [WIP] git bare revision cooker.
Feb 3 2021, 12:31 PM · Vault
tenma updated the diff for D4766: [WIP] git bare revision cooker.
  • move known_ids to an instance attribute
  • split file processing loop into processing new files

then all files

  • lru cache to avoid duplicate requests
  • typing
  • logging and asserting
  • notifying progress to vault backend
Feb 3 2021, 12:23 AM · Vault

Feb 1 2021

tenma updated the summary of D4927: lister.docs: add a lister template for the new API.
Feb 1 2021, 9:59 AM · Sprint 2021 01, Lister

Jan 26 2021

tenma updated the diff for D4731: WIP Configuration system.

Rename "singleton" to "record"

Jan 26 2021, 6:49 PM · feedback-required, Core & foundations
tenma closed D4949: tests: remove all unused conftests.
Jan 26 2021, 5:36 PM
tenma updated the diff for D4949: tests: remove all unused conftests.

Rebase

Jan 26 2021, 5:27 PM
tenma reopened D4949: tests: remove all unused conftests.
Jan 26 2021, 5:27 PM
tenma closed D4949: tests: remove all unused conftests.
Jan 26 2021, 5:10 PM
tenma committed rDLS6cd31769c102: tests: Remove no longer used conftest files (authored by tenma).
tests: Remove no longer used conftest files
Jan 26 2021, 5:09 PM
tenma updated the diff for D4949: tests: remove all unused conftests.

Reword commit

Jan 26 2021, 4:58 PM
tenma requested review of D4949: tests: remove all unused conftests.
Jan 26 2021, 4:46 PM
tenma accepted D4925: debian: Reimplement lister using new Lister API.

LGTM

Jan 26 2021, 3:11 PM
tenma updated the diff for D4927: lister.docs: add a lister template for the new API.

Add implementation instructions to the template

Jan 26 2021, 3:08 PM · Sprint 2021 01, Lister
tenma added inline comments to D4925: debian: Reimplement lister using new Lister API.
Jan 26 2021, 12:31 PM
tenma added a comment to D4925: debian: Reimplement lister using new Lister API.

In any case, bravo for the effort on this tough lister!

Jan 26 2021, 11:59 AM
tenma added inline comments to D4925: debian: Reimplement lister using new Lister API.
Jan 26 2021, 11:31 AM

Jan 25 2021

tenma added inline comments to D4940: gitlab: Support authentication.
Jan 25 2021, 6:08 PM
tenma added inline comments to D4926: Port cgit lister to the new lister api.
Jan 25 2021, 5:02 PM · Sprint 2021 01, Lister
tenma added inline comments to D4926: Port cgit lister to the new lister api.
Jan 25 2021, 4:58 PM · Sprint 2021 01, Lister
tenma closed D4907: Reimplement Gitea lister using new Lister API.
Jan 25 2021, 4:09 PM · Sprint 2021 01, Lister
tenma closed T2971: Port Gitea lister to the new Lister API as Resolved.
Jan 25 2021, 4:09 PM · Sprint 2021 01, Lister
tenma committed rDLSc220d7d299ba: gitea.tests: split and make them more thorough (authored by tenma).
gitea.tests: split and make them more thorough
Jan 25 2021, 4:00 PM
tenma committed rDLSb6a69b2ed956: gitea.lister: improve handling of credentials (authored by tenma).
gitea.lister: improve handling of credentials
Jan 25 2021, 4:00 PM
tenma committed rDLSc780ad4b4486: Reimplement Gitea lister using new Lister API (authored by tenma).
Reimplement Gitea lister using new Lister API
Jan 25 2021, 4:00 PM
tenma committed rDLS7892077a8937: tests.cli: add Gitea lister mandatory params (authored by tenma).
tests.cli: add Gitea lister mandatory params
Jan 25 2021, 4:00 PM
tenma accepted D4941: cooker: Add retry behavior on storage instance.
Jan 25 2021, 3:49 PM · Vault
tenma updated the test plan for D4907: Reimplement Gitea lister using new Lister API.
Jan 25 2021, 3:46 PM · Sprint 2021 01, Lister
tenma updated the summary of D4941: cooker: Add retry behavior on storage instance.
Jan 25 2021, 3:43 PM · Vault
tenma added a revision to T2862: vault: retry RPC calls on transient network errors: D4941: cooker: Add retry behavior on storage instance.
Jan 25 2021, 3:43 PM · Vault
tenma updated the diff for D4907: Reimplement Gitea lister using new Lister API.

improve handling of credentials

Jan 25 2021, 3:17 PM · Sprint 2021 01, Lister
tenma added inline comments to D4907: Reimplement Gitea lister using new Lister API.
Jan 25 2021, 3:14 PM · Sprint 2021 01, Lister
tenma retitled D4907: Reimplement Gitea lister using new Lister API from WIP Reimplement Gitea lister using new Lister API to Reimplement Gitea lister using new Lister API.
Jan 25 2021, 3:03 PM · Sprint 2021 01, Lister
tenma requested review of D4907: Reimplement Gitea lister using new Lister API.
Jan 25 2021, 12:04 PM · Sprint 2021 01, Lister

Jan 22 2021

tenma planned changes to D4927: lister.docs: add a lister template for the new API.
Jan 22 2021, 4:27 PM · Sprint 2021 01, Lister
tenma moved T2979: Port debian lister to the new Lister API from in-progress to code review on the Sprint 2021 01 board.
Jan 22 2021, 3:59 PM · Lister, Sprint 2021 01
tenma moved T2971: Port Gitea lister to the new Lister API from in-progress to code review on the Sprint 2021 01 board.
Jan 22 2021, 3:59 PM · Sprint 2021 01, Lister
tenma closed T2956: Port PyPI lister to the new Lister API, a subtask of T2442: Provide a unified API for listers to interact with the scheduler, as Resolved.
Jan 22 2021, 3:59 PM · Sprint 2021 01, Scheduling utilities
tenma closed T2956: Port PyPI lister to the new Lister API as Resolved.
Jan 22 2021, 3:59 PM · Sprint 2021 01, Lister
tenma requested review of D4927: lister.docs: add a lister template for the new API.
Jan 22 2021, 3:59 PM · Sprint 2021 01, Lister

Jan 21 2021

tenma committed rDLS5411141e3abe: gitlab.tests: fix erroneous import from gitea module (authored by tenma).
gitlab.tests: fix erroneous import from gitea module
Jan 21 2021, 5:01 PM
tenma closed D4906: tests: small fixes to pypi and gitlab.
Jan 21 2021, 5:01 PM
tenma committed rDLS6d22007946b8: pypi.tests: simplify requests_mock invocation (authored by tenma).
pypi.tests: simplify requests_mock invocation
Jan 21 2021, 5:01 PM
tenma added a revision to T2971: Port Gitea lister to the new Lister API: D4907: Reimplement Gitea lister using new Lister API.
Jan 21 2021, 4:26 PM · Sprint 2021 01, Lister
tenma requested review of D4906: tests: small fixes to pypi and gitlab.
Jan 21 2021, 4:23 PM

Jan 20 2021

tenma closed D4867: Reimplement PyPI lister using new Lister API.
Jan 20 2021, 3:52 PM · Lister
tenma committed rDLS62c825b8cb80: Reimplement PyPI lister using new Lister API (authored by tenma).
Reimplement PyPI lister using new Lister API
Jan 20 2021, 3:52 PM
tenma closed T2955: Port Bitbucket lister to the new Lister API, a subtask of T2442: Provide a unified API for listers to interact with the scheduler, as Resolved.
Jan 20 2021, 3:47 PM · Sprint 2021 01, Scheduling utilities
tenma closed T2955: Port Bitbucket lister to the new Lister API as Resolved.
Jan 20 2021, 3:47 PM · Sprint 2021 01, Bitbucket lister, Lister
tenma updated the diff for D4867: Reimplement PyPI lister using new Lister API.

Remove "WIP" from the commit message
Remove the lister model

Jan 20 2021, 3:46 PM · Lister
tenma closed D4843: Reimplement Bitbucket lister using new Lister API.
Jan 20 2021, 3:29 PM · Lister, Bitbucket lister
tenma committed rDLS565e7423e39f: Reimplement Bitbucket lister using new Lister API (authored by tenma).
Reimplement Bitbucket lister using new Lister API
Jan 20 2021, 3:29 PM
tenma moved T2971: Port Gitea lister to the new Lister API from Backlog to in-progress on the Sprint 2021 01 board.
Jan 20 2021, 3:17 PM · Sprint 2021 01, Lister
tenma changed the status of T2971: Port Gitea lister to the new Lister API from Open to Work in Progress.
Jan 20 2021, 3:17 PM · Sprint 2021 01, Lister

Jan 19 2021

tenma updated the diff for D4867: Reimplement PyPI lister using new Lister API.

Clean code and fix page type

Jan 19 2021, 12:05 PM · Lister
tenma updated the diff for D4843: Reimplement Bitbucket lister using new Lister API.

Revert changes to the credentials setting method, and improve corresponding test

Jan 19 2021, 11:31 AM · Lister, Bitbucket lister
tenma updated the diff for D4843: Reimplement Bitbucket lister using new Lister API.

Remove tenacity wait parameter

Jan 19 2021, 10:57 AM · Lister, Bitbucket lister
tenma updated the diff for D4843: Reimplement Bitbucket lister using new Lister API.

Remove the persistent isort conftest modification from diff

Jan 19 2021, 10:29 AM · Lister, Bitbucket lister
tenma updated the summary of D4843: Reimplement Bitbucket lister using new Lister API.
Jan 19 2021, 10:18 AM · Lister, Bitbucket lister
tenma updated the test plan for D4843: Reimplement Bitbucket lister using new Lister API.
Jan 19 2021, 10:18 AM · Lister, Bitbucket lister

Jan 18 2021

tenma updated the diff for D4843: Reimplement Bitbucket lister using new Lister API.

Have test coverage for credentials setting

Jan 18 2021, 8:32 PM · Lister, Bitbucket lister
tenma updated the diff for D4843: Reimplement Bitbucket lister using new Lister API.
  • apply @vlorentz suggestions
  • use tenacity retrying decorator through lister.utils thanks to D4869
  • remove setters no more useful after D4872
  • adapt tests accordingly
Jan 18 2021, 7:43 PM · Lister, Bitbucket lister
tenma updated the diff for D4843: Reimplement Bitbucket lister using new Lister API.
  • fix assert
  • fix typing
  • add a warning on credentials
Jan 18 2021, 9:59 AM · Lister, Bitbucket lister

Jan 17 2021

tenma updated the diff for D4867: Reimplement PyPI lister using new Lister API.
  • remove useless code as per feeback
  • improve tests
Jan 17 2021, 11:19 PM · Lister

Jan 15 2021

tenma added a comment to D4867: Reimplement PyPI lister using new Lister API.

In short, let's KISS!

Jan 15 2021, 3:52 PM · Lister
tenma accepted D4869: lister: Add utility module to ease HTTP requests rate limit handling.

It would be great to parametrize the request and error type, but unfortunately it does not seem easy to do...

Jan 15 2021, 2:42 PM
tenma added inline comments to D4866: Populate origin_visit_stats table out of the origin_visit_status topic.
Jan 15 2021, 12:29 PM
tenma added a comment to D4866: Populate origin_visit_stats table out of the origin_visit_status topic.

incremental review

Jan 15 2021, 12:08 PM
tenma requested changes to D4858: Add persistence of the field OriginVisitStatus.type.

did not see the requested change on clustering keys by vlorentz

Jan 15 2021, 11:46 AM
tenma accepted D4858: Add persistence of the field OriginVisitStatus.type.

TGTM, but needs a look by someone more knowledgeable about the DBs

Jan 15 2021, 11:43 AM
tenma added inline comments to D4864: phabricator: Add test for new lister implementation.
Jan 15 2021, 10:51 AM
tenma moved T2956: Port PyPI lister to the new Lister API from todo to code review on the Sprint 2021 01 board.
Jan 15 2021, 10:16 AM · Sprint 2021 01, Lister
tenma claimed T2956: Port PyPI lister to the new Lister API.
Jan 15 2021, 10:16 AM · Sprint 2021 01, Lister
tenma retitled D4867: Reimplement PyPI lister using new Lister API from [WIP] Reimplement PyPI lister using new Lister API to Reimplement PyPI lister using new Lister API.
Jan 15 2021, 10:12 AM · Lister