Page MenuHomeSoftware Heritage
Feed Advanced Search

Yesterday

stsp requested review of D6745: fix expansion of the Log keyword with rsync origins.
Sat, Dec 4, 7:06 PM
stsp added a revision to T3691: Implement CVS loader: D6745: fix expansion of the Log keyword with rsync origins.
Sat, Dec 4, 5:39 PM · Loader-CVS, Archive coverage
stsp closed D6585: in cvs loader tests, use f-strings to build repository URLs.
Sat, Dec 4, 5:37 PM
stsp committed rDLDCVSf36332c7e376: in cvs loader tests, use f-strings to build repository URLs (authored by stsp).
in cvs loader tests, use f-strings to build repository URLs
Sat, Dec 4, 5:36 PM
stsp closed D6708: fix expansion of multiple RCS keywords on a line via rsync.
Sat, Dec 4, 5:29 PM
stsp committed rDLDCVS939dd546b050: fix expansion of multiple RCS keywords on a line via rsync (authored by stsp).
fix expansion of multiple RCS keywords on a line via rsync
Sat, Dec 4, 5:29 PM
stsp added a comment to D6708: fix expansion of multiple RCS keywords on a line via rsync.

I guess it's currently limited to deal with "only" a 2 keywords in the same line case.
And we'll try and fix futher if any other cases is detected later.

Sat, Dec 4, 5:28 PM
stsp added inline comments to D6708: fix expansion of multiple RCS keywords on a line via rsync.
Sat, Dec 4, 4:33 PM

Wed, Dec 1

stsp requested review of D6715: add two example scripts to the snippets repository.
Wed, Dec 1, 4:11 PM

Mon, Nov 29

stsp added a revision to T3691: Implement CVS loader: D6708: fix expansion of multiple RCS keywords on a line via rsync.
Mon, Nov 29, 7:11 PM · Loader-CVS, Archive coverage
stsp added a task to D6708: fix expansion of multiple RCS keywords on a line via rsync: T3691: Implement CVS loader.
Mon, Nov 29, 7:11 PM
stsp requested review of D6708: fix expansion of multiple RCS keywords on a line via rsync.
Mon, Nov 29, 6:35 PM
stsp committed rDLDCVSbc00d6b16979: add a test for conversion of a file which contains a Header keyword (authored by stsp).
add a test for conversion of a file which contains a Header keyword
Mon, Nov 29, 2:36 PM
stsp closed D6678: attempt to avoid content differences due to paths in keywords.
Mon, Nov 29, 2:36 PM
stsp committed rDLDCVS5539ccb67b2a: attempt to avoid content differences due to paths in keywords (authored by stsp).
attempt to avoid content differences due to paths in keywords
Mon, Nov 29, 2:36 PM

Fri, Nov 26

stsp added a comment to D6678: attempt to avoid content differences due to paths in keywords.
In D6678#174111, @stsp wrote:
  • add a test for conversion of a file which contains a Header keyword
Fri, Nov 26, 3:35 PM
stsp updated the diff for D6678: attempt to avoid content differences due to paths in keywords.
  • add a test for conversion of a file which contains a Header keyword
Fri, Nov 26, 3:34 PM
stsp added a comment to D6678: attempt to avoid content differences due to paths in keywords.
In D6678#174093, @stsp wrote:

And since our tests control the absolute paths to the test repositories they also control the expanded value of keywords like $Header$.
This means the tests would pass even without this fix in place. So I am not sure such a test would really be meaningful.

Fri, Nov 26, 2:55 PM
stsp added a comment to D6678: attempt to avoid content differences due to paths in keywords.
In D6678#174093, @stsp wrote:

This means the tests would pass even without this fix in place. So I am not sure such a test would really be meaningful.

Fri, Nov 26, 2:53 PM
stsp added a comment to D6678: attempt to avoid content differences due to paths in keywords.

wow...

Good catch, thanks. Could you add a test for this (so we don't accidentally change it if we ever refactor the loader in the future)?

Fri, Nov 26, 2:50 PM

Thu, Nov 25

stsp abandoned D6684: fix regular expression used for matching RCS keywords.

This patch is wrong. Keywords stored in already-expanded form in the repository are no longer being expanded. We need a different fix for this issue.

Thu, Nov 25, 10:34 AM

Wed, Nov 24

stsp requested review of D6684: fix regular expression used for matching RCS keywords.
Wed, Nov 24, 12:31 PM
stsp added a revision to T3691: Implement CVS loader: D6684: fix regular expression used for matching RCS keywords.
Wed, Nov 24, 12:30 PM · Loader-CVS, Archive coverage
stsp added a task to D6678: attempt to avoid content differences due to paths in keywords: T3691: Implement CVS loader.
Wed, Nov 24, 12:30 PM
stsp added a revision to T3691: Implement CVS loader: D6678: attempt to avoid content differences due to paths in keywords.
Wed, Nov 24, 12:30 PM · Loader-CVS, Archive coverage
stsp added a comment to T3691: Implement CVS loader.

D6684 addresses another keyword expansion issue found while testing conversion of CVS's own history.

Wed, Nov 24, 12:30 PM · Loader-CVS, Archive coverage
stsp requested review of D6678: attempt to avoid content differences due to paths in keywords.
Wed, Nov 24, 10:54 AM
stsp added a comment to T3691: Implement CVS loader.

The above problem with the Header keyword can be worked around (at least for the GNU savannah site) with the patch in D6678.

Wed, Nov 24, 10:53 AM · Loader-CVS, Archive coverage

Mon, Nov 22

stsp closed D6638: preserve empty lines in CVS log messages over pserver.
Mon, Nov 22, 7:51 PM
stsp committed rDLDCVS34f46486f4a4: preserve empty lines in CVS log messages over pserver (authored by stsp).
preserve empty lines in CVS log messages over pserver
Mon, Nov 22, 7:51 PM

Fri, Nov 12

stsp added a comment to T3691: Implement CVS loader.

Another problem with keyword expansion found during testing:

Fri, Nov 12, 11:41 AM · Loader-CVS, Archive coverage
stsp added a revision to T3691: Implement CVS loader: D6638: preserve empty lines in CVS log messages over pserver.
Fri, Nov 12, 11:38 AM · Loader-CVS, Archive coverage
stsp added a task to D6638: preserve empty lines in CVS log messages over pserver: T3691: Implement CVS loader.
Fri, Nov 12, 11:38 AM

Thu, Nov 11

stsp requested review of D6638: preserve empty lines in CVS log messages over pserver.
Thu, Nov 11, 11:31 AM

Wed, Nov 10

stsp added a comment to T3691: Implement CVS loader.
In T3691#73518, @stsp wrote:

There is another problem related to keywords: Some CVS-based projects use custom keywords, instead of the standard $Id$ keyword. This prevents wrong expansion of $Id$ when code is imported from one project to another. Usually the project's name will be used as the custom keyword name, such as $OpenBSD$ or $NetBSD$, instead of $Id$. At present, to expand keywords correctly in this case, we need to use the pserver access method to benefit from server-side keyword expansion. But we will end up with different hashes if rsync is used to import the same origin again. We might be able to auto-detect use of custom keywords if the rsync server allows access to the CVSROOT folder, but this is not always the case. If CVSROOT is hidden from rsync, the only reliable way to detect custom keywords would be a parameter that gets passed into the loader. We could, for example, allow passing the name of a custom keyword as a parameter embedded in the origin URL.

Wed, Nov 10, 1:12 PM · Loader-CVS, Archive coverage
stsp closed D6623: add CVS commit ID support to rlog.py.
Wed, Nov 10, 12:09 PM
stsp committed rDLDCVSf5b974a00951: add CVS commit ID support to rlog.py (authored by stsp).
add CVS commit ID support to rlog.py
Wed, Nov 10, 12:09 PM

Tue, Nov 9

stsp updated the diff for D6623: add CVS commit ID support to rlog.py.

changes suggested by vlorentz

Tue, Nov 9, 4:03 PM
stsp closed D6593: handle Attic-only RCS files over CVS pserver.
Tue, Nov 9, 3:54 PM
stsp committed rDLDCVSd28a4b21c56a: handle Attic-only RCS files over CVS pserver (authored by stsp).
handle Attic-only RCS files over CVS pserver
Tue, Nov 9, 3:54 PM
stsp updated the diff for D6593: handle Attic-only RCS files over CVS pserver.

rebased patch

Tue, Nov 9, 3:51 PM
stsp closed D6592: improve test coverage of file additions and deletions.
Tue, Nov 9, 3:50 PM
stsp committed rDLDCVSd72f15f24dbd: improve test coverage of file additions and deletions (authored by stsp).
improve test coverage of file additions and deletions
Tue, Nov 9, 3:50 PM
stsp updated the diff for D6592: improve test coverage of file additions and deletions.

rebased patch

Tue, Nov 9, 3:48 PM
stsp closed D6591: display file state in progress logging output.
Tue, Nov 9, 3:47 PM
stsp committed rDLDCVSca23bc13c21b: display file state in progress logging output (authored by stsp).
display file state in progress logging output
Tue, Nov 9, 3:47 PM
stsp updated the diff for D6591: display file state in progress logging output.

rebased patch

Tue, Nov 9, 3:43 PM
stsp closed D6590: add support for RCS keyword expansion over pserver protocol.
Tue, Nov 9, 3:43 PM
stsp committed rDLDCVSf52f0e452132: add support for RCS keyword expansion over pserver protocol (authored by stsp).
add support for RCS keyword expansion over pserver protocol
Tue, Nov 9, 3:43 PM
stsp updated the diff for D6590: add support for RCS keyword expansion over pserver protocol.

rebased patch

Tue, Nov 9, 3:19 PM
stsp added a comment to T3691: Implement CVS loader.

As of D6623 the CVS loader is able to convert GNU dino correctly over both rsync and pserver access.

Tue, Nov 9, 1:30 PM · Loader-CVS, Archive coverage
stsp requested review of D6623: add CVS commit ID support to rlog.py.
Tue, Nov 9, 1:28 PM
stsp added a revision to T3691: Implement CVS loader: D6623: add CVS commit ID support to rlog.py.
Tue, Nov 9, 1:27 PM · Loader-CVS, Archive coverage
stsp added inline comments to D6593: handle Attic-only RCS files over CVS pserver.
Tue, Nov 9, 12:04 PM
stsp updated the diff for D6593: handle Attic-only RCS files over CVS pserver.

assert self.cvsroot_path instead of casting and squash all changes

Tue, Nov 9, 12:03 PM
stsp added inline comments to D6593: handle Attic-only RCS files over CVS pserver.
Tue, Nov 9, 11:19 AM

Fri, Nov 5

stsp added a comment to T3691: Implement CVS loader.

Status update:

Fri, Nov 5, 2:31 PM · Loader-CVS, Archive coverage
stsp updated the diff for D6593: handle Attic-only RCS files over CVS pserver.
  • apply style change in fetch_rlog() suggested by vlorentz
Fri, Nov 5, 1:54 PM
stsp updated the diff for D6593: handle Attic-only RCS files over CVS pserver.

fix mypy errors with much help from vlorentz

Fri, Nov 5, 1:50 PM
stsp updated the diff for D6590: add support for RCS keyword expansion over pserver protocol.

add docstring to cvsclient's checkout() function

Fri, Nov 5, 1:48 PM
stsp updated the diff for D6590: add support for RCS keyword expansion over pserver protocol.

removed cvsclient.py test code

Fri, Nov 5, 1:34 PM
stsp added inline comments to D6598: Add type annotations.
Fri, Nov 5, 1:29 PM
stsp accepted D6598: Add type annotations.
Fri, Nov 5, 1:26 PM
stsp added inline comments to D6593: handle Attic-only RCS files over CVS pserver.
Fri, Nov 5, 1:25 PM

Nov 3 2021

stsp added inline comments to D6593: handle Attic-only RCS files over CVS pserver.
Nov 3 2021, 5:37 PM
stsp added inline comments to D6593: handle Attic-only RCS files over CVS pserver.
Nov 3 2021, 5:34 PM

Oct 31 2021

stsp requested review of D6593: handle Attic-only RCS files over CVS pserver.
Oct 31 2021, 11:33 PM
stsp added a revision to T3691: Implement CVS loader: D6593: handle Attic-only RCS files over CVS pserver.
Oct 31 2021, 11:32 PM · Loader-CVS, Archive coverage

Oct 30 2021

stsp requested review of D6592: improve test coverage of file additions and deletions.
Oct 30 2021, 2:03 PM
stsp requested review of D6591: display file state in progress logging output.
Oct 30 2021, 2:03 PM
stsp added a revision to T3691: Implement CVS loader: D6590: add support for RCS keyword expansion over pserver protocol.
Oct 30 2021, 11:49 AM · Loader-CVS, Archive coverage
stsp added a task to D6590: add support for RCS keyword expansion over pserver protocol: T3691: Implement CVS loader.
Oct 30 2021, 11:49 AM
stsp requested review of D6590: add support for RCS keyword expansion over pserver protocol.
Oct 30 2021, 11:49 AM

Oct 28 2021

stsp requested review of D6585: in cvs loader tests, use f-strings to build repository URLs.
Oct 28 2021, 7:06 PM
stsp added inline comments to D6566: test checkout of file lacking trailing \n over pserver protocol.
Oct 28 2021, 7:06 PM
stsp closed D6566: test checkout of file lacking trailing \n over pserver protocol.
Oct 28 2021, 7:02 PM
stsp committed rDLDCVSbeb7fc8a023a: test checkout of file lacking trailing \n over pserver protocol (authored by stsp).
test checkout of file lacking trailing \n over pserver protocol
Oct 28 2021, 7:02 PM

Oct 27 2021

stsp requested review of D6566: test checkout of file lacking trailing \n over pserver protocol.
Oct 27 2021, 4:22 PM
stsp added a revision to T3691: Implement CVS loader: D6566: test checkout of file lacking trailing \n over pserver protocol.
Oct 27 2021, 4:20 PM · Loader-CVS, Archive coverage
stsp closed D6561: rlog: fix loading of CVS commits which have a commit ID.
Oct 27 2021, 4:01 PM
stsp committed rDLDCVS509ac801df74: rlog: fix loading of CVS commits which have a commit ID (authored by stsp).
rlog: fix loading of CVS commits which have a commit ID
Oct 27 2021, 4:01 PM
stsp updated the diff for D6561: rlog: fix loading of CVS commits which have a commit ID.

rebased patch

Oct 27 2021, 4:00 PM
stsp closed D6560: rlog: fix parsing of multiple file revisions.
Oct 27 2021, 3:59 PM
stsp committed rDLDCVS0829dc3309d7: rlog: fix parsing of multiple file revisions (authored by stsp).
rlog: fix parsing of multiple file revisions
Oct 27 2021, 3:59 PM
stsp updated the diff for D6560: rlog: fix parsing of multiple file revisions.

rebased patch

Oct 27 2021, 3:58 PM
stsp added a task to D6559: cvsclient: handle additional responses sent by server: T3691: Implement CVS loader.
Oct 27 2021, 3:55 PM
stsp added a revision to T3691: Implement CVS loader: D6559: cvsclient: handle additional responses sent by server.
Oct 27 2021, 3:55 PM · Loader-CVS, Archive coverage
stsp added a revision to T3691: Implement CVS loader: D6561: rlog: fix loading of CVS commits which have a commit ID.
Oct 27 2021, 3:55 PM · Loader-CVS, Archive coverage
stsp added a task to D6561: rlog: fix loading of CVS commits which have a commit ID: T3691: Implement CVS loader.
Oct 27 2021, 3:55 PM
stsp added a revision to T3691: Implement CVS loader: D6560: rlog: fix parsing of multiple file revisions.
Oct 27 2021, 3:55 PM · Loader-CVS, Archive coverage
stsp added a task to D6560: rlog: fix parsing of multiple file revisions: T3691: Implement CVS loader.
Oct 27 2021, 3:55 PM
stsp committed rDLDCVS6ff0b4473c2b: apply style tweaks suggested by vlorentz and reformatted by black (authored by stsp).
apply style tweaks suggested by vlorentz and reformatted by black
Oct 27 2021, 3:52 PM
stsp closed D6559: cvsclient: handle additional responses sent by server.
Oct 27 2021, 3:52 PM
stsp committed rDLDCVS3a2f06b3d5fb: cvsclient: handle additional responses sent by server (authored by stsp).
cvsclient: handle additional responses sent by server
Oct 27 2021, 3:52 PM
stsp updated the diff for D6559: cvsclient: handle additional responses sent by server.
  • cvsclient: handle additional responses sent by server
  • apply style tweaks suggested by vlorentz and reformatted by black
Oct 27 2021, 3:51 PM
stsp closed D6558: cvsclient: handle files which lack a trailing newline.
Oct 27 2021, 3:45 PM
stsp committed rDLDCVSd3b3344bc26d: cvsclient: handle files which lack a trailing newline (authored by stsp).
cvsclient: handle files which lack a trailing newline
Oct 27 2021, 3:45 PM
stsp added a comment to D6558: cvsclient: handle files which lack a trailing newline.

Could you add a test?

Oct 27 2021, 1:11 PM
stsp added a comment to T3691: Implement CVS loader.

Current CVS loader status update:

Oct 27 2021, 12:36 PM · Loader-CVS, Archive coverage
stsp requested review of D6561: rlog: fix loading of CVS commits which have a commit ID.
Oct 27 2021, 12:28 PM