Page MenuHomeSoftware Heritage

make CVS loader create one snapshot per visit
ClosedPublic

Authored by stsp on Dec 7 2021, 10:59 AM.

Details

Summary

The CVS loader used to create one snapshot per loaded revision.
As pointed out by ardumont in D6745, this is wrong; Other loaders
create only one snapshot per visit.
Fix this issue and adjust tests expectations accordingly.

While here, show SHW IDs of loaded revisions and snapshots in regular
"info" log output, rather than only in "debug" log output. Previously,
only CVS-related data was shown at the "info" log level. Showing both
CVs and SWH data in log output is more informative.

Diff Detail

Repository
rDLDCVS CVS Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6758 (id=24536)

Rebasing onto 099959bbfa...

Current branch diff-target is up to date.
Changes applied before test
commit 5298a8f9500e84899c308fce9b31f070c04f3528
Author: Stefan Sperling <stsp@stsp.name>
Date:   Tue Dec 7 10:53:10 2021 +0100

    make CVS loader create one snapshot per visit
    
    The CVS loader used to create one snapshot per loaded revision.
    As pointed out by ardumont in D6745, this is wrong; Other loaders
    create only one snapshot per visit.
    Fix this issue and adjust tests expectations accordingly.
    
    While here, show SHW IDs of loaded revisions and snapshots in regular
    "info" log output, rather than only in "debug" log output. Previously,
    only CVS-related data was shown at the "info" log level. Showing both
    CVs and SWH data in log output is more informative.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/74/ for more details.

stsp requested review of this revision.Dec 7 2021, 11:00 AM
ardumont added a subscriber: ardumont.

Awesome, thanks.

Now, given the old code, that makes sense there were too much snapshot ;)

This revision is now accepted and ready to land.Dec 7 2021, 11:18 AM