Page MenuHomeSoftware Heritage

preserve empty lines in CVS log messages over pserver
ClosedPublic

Authored by stsp on Thu, Nov 11, 11:28 AM.

Details

Summary

Empty lines sent by the CVS server in rlog output were being stripped
by our custom cvs client implementation. Unfortunately, this resulted
in empty lines being stripped from CVS log messages, which is fixed
with this commit. The rsync access method already preserved log
messages properly, and now the pserver access method does the same.

Diff Detail

Repository
rDLDCVS CVS Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6638 (id=24129)

Rebasing onto f5b974a009...

Current branch diff-target is up to date.
Changes applied before test
commit 34f46486f4a489574061dadd688b2a79e39ca10c
Author: Stefan Sperling <stsp@stsp.name>
Date:   Thu Nov 11 11:24:45 2021 +0100

    preserve empty lines in CVS log messages over pserver
    
    Empty lines sent by the CVS server in rlog output were being stripped
    by our custom cvs client implementation. Unfortunately, this resulted
    in empty lines being stripped from CVS log messages, which is fixed
    with this commit. The rsync access method already preserved log
    messages properly, and now the pserver access method does the same.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/62/ for more details.

stsp requested review of this revision.Thu, Nov 11, 11:31 AM
This revision is now accepted and ready to land.Mon, Nov 15, 8:33 AM