Page MenuHomeSoftware Heritage
Feed Advanced Search

Oct 21 2021

anlambert updated the diff for D6519: Jenkins job for swh-docs diffs test.

Introduce warning to check the CI build fails

Oct 21 2021, 1:49 PM
anlambert committed rCJSWHee059076312e: jobs/swh-docs: Add missing Jenkins DDOC folder creation (authored by anlambert).
jobs/swh-docs: Add missing Jenkins DDOC folder creation
Oct 21 2021, 1:45 PM
anlambert closed T3661: docs: Activate build on docs diff as Resolved by committing rCJSWH6e1bc67c9ee5: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.
Oct 21 2021, 1:33 PM · Documentation
anlambert closed D6523: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.
Oct 21 2021, 1:33 PM
anlambert committed rCJSWH6e1bc67c9ee5: jobs/swh-docs: Add job to build doc when submitting phabricator diffs (authored by anlambert).
jobs/swh-docs: Add job to build doc when submitting phabricator diffs
Oct 21 2021, 1:33 PM
anlambert updated the diff for D6523: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.

Remove file committed by mistake

Oct 21 2021, 1:32 PM
anlambert updated the diff for D6523: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.

Use single quotes for string litteral in groovy script

Oct 21 2021, 1:31 PM
anlambert requested review of D6523: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.
Oct 21 2021, 12:24 PM
anlambert added a revision to T3661: docs: Activate build on docs diff: D6523: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.
Oct 21 2021, 12:24 PM · Documentation
anlambert updated the diff for D6519: Jenkins job for swh-docs diffs test.

Rebase

Oct 21 2021, 11:58 AM

Oct 20 2021

anlambert added a comment to T3661: docs: Activate build on docs diff.

I have created a new Jenkins pipeline job manually to experiment on setting up that new CI build.

Oct 20 2021, 6:17 PM · Documentation
anlambert committed rCDFJ7d453b55a904: sphinx/Dockerfile: Install pyarcanist in doc build environment (authored by anlambert).
sphinx/Dockerfile: Install pyarcanist in doc build environment
Oct 20 2021, 5:00 PM
anlambert closed D6522: sphinx/Dockerfile: Install pyarcanist in doc build environment.
Oct 20 2021, 5:00 PM
anlambert requested review of D6522: sphinx/Dockerfile: Install pyarcanist in doc build environment.
Oct 20 2021, 4:59 PM
anlambert added a revision to T3661: docs: Activate build on docs diff: D6522: sphinx/Dockerfile: Install pyarcanist in doc build environment.
Oct 20 2021, 4:59 PM · Documentation
anlambert requested review of D6519: Jenkins job for swh-docs diffs test.
Oct 20 2021, 4:51 PM
anlambert closed D6518: admin/deposit: Allow users with permission to list their deposits.
Oct 20 2021, 4:05 PM
anlambert committed rDWAPPSa8cfc14b4a5c: admin/deposit: Allow users with permission to list their deposits (authored by anlambert).
admin/deposit: Allow users with permission to list their deposits
Oct 20 2021, 4:05 PM
anlambert requested review of D6518: admin/deposit: Allow users with permission to list their deposits.
Oct 20 2021, 2:57 PM
anlambert added a revision to T3174: Filter deposit-admin view by deposit client on admin (moderation) page: D6518: admin/deposit: Allow users with permission to list their deposits.
Oct 20 2021, 2:02 PM · Monitoring, SWORD deposit, Web app
anlambert closed T3257: Template the save code now rejection reason to ease operator workflow, a subtask of T3256: Propose reason for rejecting a save code now, as Resolved.
Oct 20 2021, 12:36 PM · Save Code Now, Easy hack, Web app
anlambert closed T3257: Template the save code now rejection reason to ease operator workflow as Resolved.

It has been implemented and deployed to production, closing this.

Oct 20 2021, 12:36 PM · Save Code Now, Easy hack, Web app
anlambert closed T3256: Propose reason for rejecting a save code now, a subtask of T3252: Better handling of erroneous origins submitted to save code now, as Resolved.
Oct 20 2021, 12:36 PM · System administration, Save Code Now, Web app
anlambert closed T3256: Propose reason for rejecting a save code now as Resolved.

It has been implemented and deployed to production, closing this.

Oct 20 2021, 12:36 PM · Save Code Now, Easy hack, Web app
anlambert closed D6516: docker/conf: Fix memcache URI.
Oct 20 2021, 12:08 PM
anlambert committed rDENV59aba314af8f: docker/conf: Fix memcache URI (authored by anlambert).
docker/conf: Fix memcache URI
Oct 20 2021, 12:08 PM
anlambert requested review of D6516: docker/conf: Fix memcache URI.
Oct 20 2021, 11:44 AM
anlambert closed D6511: tests: Fix execution when building debian packages.
Oct 20 2021, 11:30 AM
anlambert committed rDWAPPSba1801812eff: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Oct 20 2021, 11:30 AM
anlambert committed rDWAPPS2603e9cefe4a: tests: Fix execution when building debian packages (authored by anlambert).
tests: Fix execution when building debian packages
Oct 20 2021, 11:30 AM
anlambert accepted D6514: Add docstring to runner and listener modules.

Looks goo to me.

Oct 20 2021, 11:19 AM
anlambert accepted D6515: Drop deprecated listener module.
Oct 20 2021, 10:56 AM

Oct 19 2021

anlambert closed D6502: assets/origin-save: Display rejection reason in request info popover.
Oct 19 2021, 4:12 PM
anlambert committed rDWAPPS96b3d287ed50: assets/origin-save: Display rejection reason in request info popover (authored by anlambert).
assets/origin-save: Display rejection reason in request info popover
Oct 19 2021, 4:12 PM
anlambert committed rDWAPPS6c2792e9090f: assets/admin/origin-save: Enable to add note when rejecting a request (authored by anlambert).
assets/admin/origin-save: Enable to add note when rejecting a request
Oct 19 2021, 4:12 PM
anlambert closed D6501: assets/admin/origin-save: Enable to add note when rejecting a request.
Oct 19 2021, 4:12 PM
anlambert committed rDWAPPS9cf83ddceafe: Makefile.local: Remove correct sqlite tests database (authored by anlambert).
Makefile.local: Remove correct sqlite tests database
Oct 19 2021, 4:12 PM
anlambert updated the diff for D6502: assets/origin-save: Display rejection reason in request info popover.

Rebase

Oct 19 2021, 3:54 PM
anlambert updated the diff for D6501: assets/admin/origin-save: Enable to add note when rejecting a request.

Rebase and fix a couple of typos in cypress test comments

Oct 19 2021, 3:53 PM
anlambert closed D6503: api/private/deposit_list: Allow to filter deposits by client username.
Oct 19 2021, 3:52 PM
anlambert committed rDDEP801a0274c44d: api/private/deposit_list: Allow to filter deposits by client username (authored by anlambert).
api/private/deposit_list: Allow to filter deposits by client username
Oct 19 2021, 3:52 PM
anlambert added a comment to D6502: assets/origin-save: Display rejection reason in request info popover.

lgtm

Oct 19 2021, 3:48 PM
anlambert added a comment to D6503: api/private/deposit_list: Allow to filter deposits by client username.

That was quick ;)
Thanks.

Oct 19 2021, 2:41 PM
anlambert closed D6505: browse/content: Fix error when a staff user browses a not found content.
Oct 19 2021, 2:27 PM
anlambert committed rDWAPPSb72fd7f91746: browse/content: Fix error when a staff user browses a not found content (authored by anlambert).
browse/content: Fix error when a staff user browses a not found content
Oct 19 2021, 2:27 PM
anlambert requested review of D6505: browse/content: Fix error when a staff user browses a not found content.
Oct 19 2021, 2:20 PM
anlambert requested review of D6503: api/private/deposit_list: Allow to filter deposits by client username.
Oct 19 2021, 1:51 PM
anlambert added a revision to T3174: Filter deposit-admin view by deposit client on admin (moderation) page: D6503: api/private/deposit_list: Allow to filter deposits by client username.
Oct 19 2021, 1:48 PM · Monitoring, SWORD deposit, Web app
anlambert updated the summary of D6502: assets/origin-save: Display rejection reason in request info popover.
Oct 19 2021, 12:33 PM
anlambert updated the summary of D6501: assets/admin/origin-save: Enable to add note when rejecting a request.
Oct 19 2021, 12:32 PM
anlambert requested review of D6502: assets/origin-save: Display rejection reason in request info popover.
Oct 19 2021, 12:30 PM
anlambert requested review of D6501: assets/admin/origin-save: Enable to add note when rejecting a request.
Oct 19 2021, 12:28 PM
anlambert added a revision to T3256: Propose reason for rejecting a save code now: D6502: assets/origin-save: Display rejection reason in request info popover.
Oct 19 2021, 11:21 AM · Save Code Now, Easy hack, Web app
anlambert added a revision to T3256: Propose reason for rejecting a save code now: D6501: assets/admin/origin-save: Enable to add note when rejecting a request.
Oct 19 2021, 11:20 AM · Save Code Now, Easy hack, Web app
anlambert added a revision to T3257: Template the save code now rejection reason to ease operator workflow: D6501: assets/admin/origin-save: Enable to add note when rejecting a request.
Oct 19 2021, 11:20 AM · Save Code Now, Easy hack, Web app

Oct 18 2021

anlambert accepted D6496: Use swh_storage fixture for cli tests.

Looks good to me, plus it aligns the tests with production settings.

Oct 18 2021, 3:06 PM

Oct 15 2021

anlambert closed T3657: Fix faq menu rendering glitch in docs.s.o as Resolved by committing rDDOC788598eb8eb6: docs, user: Fix faq menu rendering glitch.
Oct 15 2021, 5:53 PM · Documentation
anlambert closed D6489: docs, user: Fix faq menu rendering glitch.
Oct 15 2021, 5:53 PM
anlambert committed rDDOC788598eb8eb6: docs, user: Fix faq menu rendering glitch (authored by anlambert).
docs, user: Fix faq menu rendering glitch
Oct 15 2021, 5:53 PM
anlambert updated the diff for D6489: docs, user: Fix faq menu rendering glitch.

Remove FAQ section in main doc page with duplicated toctree and add link to FAQ in Getting started top level section.

Oct 15 2021, 5:52 PM
anlambert accepted D6491: Migrate onboarding page from the wiki to sysadm docs.
Oct 15 2021, 5:39 PM
anlambert accepted D6488: Migrate outboarding page from the intranet to sysadm docs.
Oct 15 2021, 5:38 PM
anlambert committed rDDOCd8aaa5bcd680: Fix some errors detected by make check (authored by anlambert).
Fix some errors detected by make check
Oct 15 2021, 5:33 PM
anlambert closed D6490: Fix some errors detected by make check.
Oct 15 2021, 5:33 PM
anlambert closed T3575: Filter out sdist archives that are not of interest as Resolved.

Fix has been deployed to production, closing this.

Oct 15 2021, 5:30 PM · PyPI loader
anlambert requested review of D6490: Fix some errors detected by make check.
Oct 15 2021, 5:27 PM
anlambert added inline comments to D6489: docs, user: Fix faq menu rendering glitch.
Oct 15 2021, 5:08 PM
anlambert added inline comments to D6489: docs, user: Fix faq menu rendering glitch.
Oct 15 2021, 5:07 PM
anlambert requested review of D6489: docs, user: Fix faq menu rendering glitch.
Oct 15 2021, 4:47 PM
anlambert added a revision to T3657: Fix faq menu rendering glitch in docs.s.o: D6489: docs, user: Fix faq menu rendering glitch.
Oct 15 2021, 4:47 PM · Documentation
anlambert closed D6476: tests: Ensure failing test with random fixture data can be reproduced.
Oct 15 2021, 4:40 PM
anlambert committed rDWAPPS61b80b8b2314: tests: Ensure failing test with random fixture data can be reproduced (authored by anlambert).
tests: Ensure failing test with random fixture data can be reproduced
Oct 15 2021, 4:40 PM
anlambert closed D6471: tests/conftest: Put filtered input data in cache.
Oct 15 2021, 4:40 PM
anlambert committed rDWAPPSefbf0cdc2c4d: tests/conftest: Put filtered input data in cache (authored by anlambert).
tests/conftest: Put filtered input data in cache
Oct 15 2021, 4:40 PM
anlambert updated the diff for D6476: tests: Ensure failing test with random fixture data can be reproduced.

Rebase

Oct 15 2021, 4:15 PM
anlambert updated the diff for D6471: tests/conftest: Put filtered input data in cache.

Rebase

Oct 15 2021, 4:14 PM
anlambert closed D6486: sphinx/conf.py: Remove no longer needed httpdomain hacks.
Oct 15 2021, 1:33 PM
anlambert committed rDDOCfcb0bb5edc33: sphinx/conf.py: Remove no longer needed httpdomain hacks (authored by anlambert).
sphinx/conf.py: Remove no longer needed httpdomain hacks
Oct 15 2021, 1:33 PM
anlambert requested review of D6486: sphinx/conf.py: Remove no longer needed httpdomain hacks.
Oct 15 2021, 1:11 PM
anlambert closed D6484: jobs/swh-environment: Simplify build script and workaround pip issue.
Oct 15 2021, 11:56 AM
anlambert committed rCJSWHf9d56e551c7c: jobs/swh-environment: Simplify build script and workaround pip issue (authored by anlambert).
jobs/swh-environment: Simplify build script and workaround pip issue
Oct 15 2021, 11:56 AM
anlambert updated the summary of D6484: jobs/swh-environment: Simplify build script and workaround pip issue.
Oct 15 2021, 11:52 AM
anlambert updated the diff for D6484: jobs/swh-environment: Simplify build script and workaround pip issue.

Remove the use of --no-use-pep517 as tree_sitter dependency fails to install otherwise.

Oct 15 2021, 11:51 AM
anlambert added inline comments to D6484: jobs/swh-environment: Simplify build script and workaround pip issue.
Oct 15 2021, 11:46 AM
anlambert added a comment to T3663: Make the swh-environment jenkins job green and activate notifications.
09:13:54 Collecting tree-sitter
09:13:54   Using cached tree_sitter-0.19.0.tar.gz (112 kB)
09:13:54 ERROR: Disabling PEP 517 processing is invalid: project specifies a build backend of setuptools.build_meta in pyproject.toml
Oct 15 2021, 11:37 AM · System administration
anlambert added a reviewer for D6484: jobs/swh-environment: Simplify build script and workaround pip issue: Reviewers.
Oct 15 2021, 11:29 AM
anlambert added a comment to T3663: Make the swh-environment jenkins job green and activate notifications.

I pushed D6484 to fix the build issue. Instead of pinning pip version, I used the --no-use-pep517 pip option as suggested in the pip github issue.

Oct 15 2021, 11:28 AM · System administration
anlambert added a revision to T3663: Make the swh-environment jenkins job green and activate notifications: D6484: jobs/swh-environment: Simplify build script and workaround pip issue.
Oct 15 2021, 11:26 AM · System administration
anlambert requested review of D6484: jobs/swh-environment: Simplify build script and workaround pip issue.
Oct 15 2021, 11:26 AM
anlambert added a comment to T3663: Make the swh-environment jenkins job green and activate notifications.

I quickly hacked on Jenkins job to remove the pip upgrade but the default pip version on the docker image is too outdated
and some swh dependencies will fail to install, see console output.

Oct 15 2021, 11:02 AM · System administration
anlambert added a comment to D6479: bib/install: disable pip self ugprade.

There is a typo in commit message: s/bib/bin/.

Oct 15 2021, 10:52 AM
anlambert accepted D6481: Revert "journal_client: Add origins processing".
Oct 15 2021, 10:50 AM

Oct 14 2021

anlambert added a comment to T3648: Fix swh-docs's broken dev build.

/me *sigh* it's still red...

That really should be a team effort, to strive to keep our builds green.
So for this build, i concur with @anlambert, we should make it build during diff.

15:14 <+anlambert> ardumont: in order to catch sphinx issues in swh-docs, I was thinking of running the swh-docs/dev Jenkins job when submitting a diff to swh-docs. I think we only need to setup a new harbomaster build plan for that (https://forge.softwareheritage.org/harbormaster/plan/).
15:14 <+ardumont> anlambert: yes, that'd be good because i'm still on T3648 and that's really frustrating

@anlambert thx for the suggestion ^

Oct 14 2021, 6:43 PM · Documentation
anlambert updated the diff for D6476: tests: Ensure failing test with random fixture data can be reproduced.

Remove not needed sorting operation on swhids list.

Oct 14 2021, 6:38 PM
anlambert added inline comments to D6476: tests: Ensure failing test with random fixture data can be reproduced.
Oct 14 2021, 6:35 PM
anlambert accepted D6475: Reference ingested but discontinued bitbucket mercurial origins.

Looks good to me, and yes those static dicts should be moved out of swh-web but I do not have a proper solution in mind so far.

Oct 14 2021, 5:10 PM
anlambert updated the diff for D6476: tests: Ensure failing test with random fixture data can be reproduced.

Rebase

Oct 14 2021, 5:03 PM
anlambert updated the diff for D6471: tests/conftest: Put filtered input data in cache.

Rebase

Oct 14 2021, 5:03 PM
anlambert committed rDWAPPSed2c2dbed959: api/origin_save: Do not fetch savable visit types when running tests (authored by anlambert).
api/origin_save: Do not fetch savable visit types when running tests
Oct 14 2021, 5:01 PM
anlambert committed rDWAPPS5cab8a54553e: tests/browse/test_directory: Fix a couple of flaky tests (authored by anlambert).
tests/browse/test_directory: Fix a couple of flaky tests
Oct 14 2021, 5:01 PM