Page MenuHomeSoftware Heritage

swh.storage: Test get_storage implementation
ClosedPublic

Authored by ardumont on Oct 8 2019, 2:30 PM.

Details

Summary

Check the current get_storage implementation.

In the following diffs, new ones will get added.

Related D2384 D2385

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 8171
Build 11780: tox-on-jenkinsJenkins
Build 11779: arc lint + arc unit

Event Timeline

Fix commit content (some code should not have been included...)

Update:

  • ci for following diffs seems off
  • content displayed for the diff is off as well
swh/storage/tests/test_init.py
28

maybe use patch or something.

swh/storage/tests/test_init.py
22–28

I don't understand what the problem is

swh/storage/tests/test_init.py
22–28

It fails to instantiate because i probably did not setup the right stanza for a db connection.

swh/storage/tests/test_init.py
22–28

Can you fix it before landing the diff?

Fix missing implementation check

swh/storage/tests/test_init.py
22–28

Yes, i'll try:

Here is the message by the way:

swh.storage.exc.StorageDBError: An unexpected error occurred in the backend: could not translate host name "db" to address: Name or service not known
22–28

done

ardumont added a project: Storage manager.
ardumont edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Oct 8 2019, 4:32 PM