Differential D2083

swh.storage: Test get_storage implementation
ClosedPublic
Actions

Authored by ardumont on Oct 8 2019, 2:30 PM.

Tags

Subscribers

None

Details

Reviewers

olasd
vlorentz
douardda

Group Reviewers

Commits

rDSTOC02b25f07751c: swh.storage: Test get_storage implementation
rDSTO02b25f07751c: swh.storage: Test get_storage implementation

Summary

Check the current get_storage implementation.

In the following diffs, new ones will get added.

Related D2384 D2385

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 8171
Build 11780: tox-on-jenkins	Jenkins
Build 11779: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 8 2019, 2:30 PM

Fix commit content (some code should not have been included...)

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/665/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/665/console

Harbormaster failed remote builds in B8170: Diff 7000!Oct 8 2019, 2:35 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/666/ for more details.

Harbormaster completed remote builds in B8171: Diff 7001.Oct 8 2019, 2:39 PM

ardumont added a child revision: D2084: swh.storage.filter: Add filtering storage implementation.Oct 8 2019, 2:40 PM

Update:

ci for following diffs seems off
content displayed for the diff is off as well

ardumont added inline comments.Oct 8 2019, 2:49 PM

swh/storage/tests/test_init.py
28	maybe use patch or something.

vlorentz added inline comments.Oct 8 2019, 2:51 PM

swh/storage/tests/test_init.py
22–28	I don't understand what the problem is

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/670/ for more details.

Harbormaster completed remote builds in B8174: Diff 7004.Oct 8 2019, 2:53 PM

ardumont added inline comments.Oct 8 2019, 2:53 PM

swh/storage/tests/test_init.py
22–28	It fails to instantiate because i probably did not setup the right stanza for a db connection.

vlorentz added inline comments.Oct 8 2019, 3:03 PM

swh/storage/tests/test_init.py
22–28	Can you fix it before landing the diff?

Fix missing implementation check

swh/storage/tests/test_init.py
22–28	Yes, i'll try: Here is the message by the way: swh.storage.exc.StorageDBError: An unexpected error occurred in the backend: could not translate host name "db" to address: Name or service not known
22–28	done

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/678/ for more details.

Harbormaster completed remote builds in B8183: Diff 7013.Oct 8 2019, 4:20 PM

ardumont edited the summary of this revision. (Show Details)Oct 8 2019, 4:24 PM

ardumont added a project: Storage manager.

ardumont edited the summary of this revision. (Show Details)

vlorentz accepted this revision.Oct 8 2019, 4:32 PM

This revision is now accepted and ready to land.Oct 8 2019, 4:32 PM

Closed by commit rDSTO02b25f07751c: swh.storage: Test get_storage implementation (authored by ardumont). · Explain WhyOct 8 2019, 4:42 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO02b25f07751c: swh.storage: Test get_storage implementation.

ardumont added a commit: rDSTOC02b25f07751c: swh.storage: Test get_storage implementation.Oct 30 2019, 5:22 PM

Revision Contents
Changeset List

Path

Size

swh/

storage/

15 lines

tests/

40 lines

Diff 7001

swh/storage/init.py

Loading...

swh/storage/tests/test_init.py

Loading...