Differential D2384

api/snapshot: Handle aliases chain when resolving real branch target
ClosedPublic
Actions

Authored by anlambert on Dec 2 2019, 3:28 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDWAPPS11cf6b1b2766: api/snapshot: Handle aliases chain when resolving real branch target

Summary

Hypothesis can generate chain of aliases in a snapshot content. We could also encounter
such cases in real world data so we need to handle it.

Test Plan

This issue was discovered by an already written test when using the slow hypothesis
profile mode.

Depends on D2382

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Dec 2 2019, 3:28 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 2 2019, 3:28 PM

Harbormaster failed remote builds in B9467: Diff 8393!Dec 2 2019, 3:29 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/419/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/419/console

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/820/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/820/console

anlambert removed a parent revision: D2383: hypothesis_strategies/snapshots: Explain last post-processing step.Dec 2 2019, 3:29 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/821/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/420/ for more details.

Harbormaster completed remote builds in B9467: Diff 8393.Dec 2 2019, 3:40 PM

anlambert removed a parent revision: D2382: requirements: Pin mypy and django-stubs version.Dec 2 2019, 3:56 PM

anlambert mentioned this in D2383: hypothesis_strategies/snapshots: Explain last post-processing step.Dec 2 2019, 7:49 PM

anlambert edited the test plan for this revision. (Show Details)Dec 2 2019, 8:04 PM

anlambert added a parent revision: D2382: requirements: Pin mypy and django-stubs version.

anlambert removed a parent revision: D2382: requirements: Pin mypy and django-stubs version.

This is crying for a "lazy-loaded snapshot object" abstraction in swh.storage, but I guess that's a good step up from the status quo :)

This revision is now accepted and ready to land.Dec 3 2019, 10:36 AM

Rebase

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/825/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/423/ for more details.

Harbormaster completed remote builds in B9478: Diff 8403.Dec 3 2019, 10:49 AM

Closed by commit rDWAPPS11cf6b1b2766: api/snapshot: Handle aliases chain when resolving real branch target (authored by anlambert). · Explain WhyDec 3 2019, 2:03 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS11cf6b1b2766: api/snapshot: Handle aliases chain when resolving real branch target.

Revision Contents
Changeset List

Path

Size

swh/

web/

api/

views/

snapshot.py

31 lines

Diff 8407

View Options

swh/web/api/views/snapshot.py

api/snapshot: Handle aliases chain when resolving real branch targetClosedPublicActions