Page MenuHomeSoftware Heritage

api/snapshot: Handle aliases chain when resolving real branch target
ClosedPublic

Authored by anlambert on Dec 2 2019, 3:28 PM.

Details

Summary

Hypothesis can generate chain of aliases in a snapshot content. We could also encounter
such cases in real world data so we need to handle it.

Test Plan

This issue was discovered by an already written test when using the slow hypothesis
profile mode.

Depends on D2382

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Dec 2 2019, 3:28 PM
olasd accepted this revision.Dec 3 2019, 10:36 AM
olasd added a subscriber: olasd.

This is crying for a "lazy-loaded snapshot object" abstraction in swh.storage, but I guess that's a good step up from the status quo :)

This revision is now accepted and ready to land.Dec 3 2019, 10:36 AM