phabricator: refactor PhabricatorLister's constructor
ClosedPublic
Actions

swh/lister/phabricator/lister.py
23	I forgot to mention to check the tasks module. i think it's broken now as it explicits the `forge_url` there (in my current local version though at least ;) I'm not sure where this is coming from (it should but i don't think it is coming from the plugin refactoring yet).

rebase

Harbormaster failed remote builds in B7567: Diff 6504!Sep 2 2019, 12:17 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/326/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/326/console

rebase

This revision was landed with ongoing or failed builds.Sep 2 2019, 1:17 PM

Closed by commit rDLS87cec2f5c39e: phabricator: refactor PhabricatorLister's constructor (authored by douardda). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B7574: Diff 6511!Sep 2 2019, 1:18 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/332/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/332/console

ardumont added inline comments.Sep 3 2019, 11:01 AM

swh/lister/phabricator/lister.py

@dourdda sadly, I was right! :)

After tagging the new scheduler (and rebuilding docker container)

swh-lister_1                  |   File "/srv/softwareheritage/venv/lib/python3.7/site-packages/swh/lister/cli.py", line 116, in get_lister
swh-lister_1                  |     override_config=override_conf)
swh-lister_1                  | TypeError: __init__() got an unexpected keyword argument 'forge_url'

I'll fix that ;)