Page MenuHomeSoftware Heritage
Differential D828

Remove mocks and use hypothesis in api directory endpoints tests
ClosedPublic
Actions

Authored by anlambert on Dec 14 2018, 7:17 PM.

Details

Reviewers
vlorentz
ardumont
Group Reviewers
Reviewers
Commits
R65:decefe13badc: tests.api.views.test_directory: Remove mocks and use hypothesis
rDWAPPSdecefe13badc: tests.api.views.test_directory: Remove mocks and use hypothesis
Summary

Fouth diff exposing the work I have done so far on improving swh-web tests.
In this one, remove the mocks by rewriting the tests using hypothesis for the
directory endpoints in the web api.

Related T1271

Depends on D827

Diff Detail

Repository
rDWAPPS Web applications
Branch
tests-improvements-diff4
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3123
Build 3998: tox-on-jenkinsJenkins
Build 3997: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 14 2018, 7:17 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 14 2018, 7:17 PM
Harbormaster failed remote builds in B3058: Diff 2628!Dec 14 2018, 7:17 PM
swh-public-ci added a subscriber: swh-public-ci.Dec 14 2018, 7:18 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/45/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/45/console

anlambert added a child revision: D829: Remove storage mocks and use hypothesis in service tests.Dec 14 2018, 7:22 PM
vlorentz accepted this revision.Dec 14 2018, 7:39 PM
This revision is now accepted and ready to land.Dec 14 2018, 7:39 PM
ardumont accepted this revision.Dec 15 2018, 9:28 AM
ardumont added a subscriber: ardumont.

That's cool.

And in the end that was not 'removing the mocks', that was migrating away from them.
Replacing them with something better ;)

That was my initial source of disagreement.

anlambert retitled this revision from swh-web: Remove mocks and use hypothesis in api directory endpoints tests to Remove mocks and use hypothesis in api directory endpoints tests.Dec 17 2018, 10:42 AM
anlambert updated this revision to Diff 2672.Dec 17 2018, 4:41 PM

Rebase after D827 update

Harbormaster failed remote builds in B3106: Diff 2672!Dec 17 2018, 4:42 PM
swh-public-ci added a comment.Dec 17 2018, 4:42 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/50/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/50/console

anlambert updated this revision to Diff 2679.Dec 17 2018, 5:23 PM

Rebase after D827 update

Harbormaster failed remote builds in B3113: Diff 2679!Dec 17 2018, 5:24 PM
swh-public-ci added a comment.Dec 17 2018, 5:24 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/54/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/54/console

anlambert updated this revision to Diff 2691.Dec 18 2018, 2:35 PM

Rebase after D827 update

Harbormaster failed remote builds in B3123: Diff 2691!Dec 18 2018, 2:35 PM
swh-public-ci added a comment.Dec 18 2018, 2:35 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/57/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/57/console

anlambert updated this revision to Diff 2700.Dec 18 2018, 3:03 PM

Rebase

Harbormaster failed remote builds in B3132: Diff 2700!Dec 18 2018, 3:06 PM
swh-public-ci added a comment.Dec 18 2018, 3:06 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/61/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/61/console

Closed by commit rDWAPPSdecefe13badc: tests.api.views.test_directory: Remove mocks and use hypothesis (authored by anlambert). · Explain WhyDec 18 2018, 3:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
web/
tests/
api/
views/
148 lines

Diff 2691

View Options

swh/web/tests/api/views/test_directory.py

Loading...
About · Developer information · Legal