Page MenuHomeSoftware Heritage

Remove mocks and use hypothesis in api directory endpoints tests
ClosedPublic

Authored by anlambert on Dec 14 2018, 7:17 PM.

Details

Summary

Fouth diff exposing the work I have done so far on improving swh-web tests.
In this one, remove the mocks by rewriting the tests using hypothesis for the
directory endpoints in the web api.

Related T1271

Depends on D827

Diff Detail

Repository
rDWAPPS Web applications
Branch
tests-improvements-diff4
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3113
Build 3983: tox-on-jenkinsJenkins
Build 3982: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Dec 14 2018, 7:39 PM
ardumont added a subscriber: ardumont.

That's cool.

And in the end that was not 'removing the mocks', that was migrating away from them.
Replacing them with something better ;)

That was my initial source of disagreement.

anlambert retitled this revision from swh-web: Remove mocks and use hypothesis in api directory endpoints tests to Remove mocks and use hypothesis in api directory endpoints tests.Dec 17 2018, 10:42 AM
This revision was automatically updated to reflect the committed changes.