Page MenuHomeSoftware Heritage

Stop using the deprecated 'TimestampWithTimezone.offset' attribute
ClosedPublic

Authored by vlorentz on Jan 21 2022, 12:55 PM.

Details

Summary

It will be replaced by what is currently called 'offset_bytes'

Test Plan

will fail because depends on D7005

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26245
Build 41030: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 41029: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D7006 (id=25402)

Rebasing onto 34ff6c672a...

Current branch diff-target is up to date.
Changes applied before test
commit b53e1d7005d0c2e1e3b995dbee3fcee9bfa3a556
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jan 21 12:55:01 2022 +0100

    Stop using the deprecated 'TimestampWithTimezone.offset' attribute
    
    It will be replaced by what is currently called 'offset_bytes'

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/696/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/696/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 21 2022, 12:56 PM
Harbormaster failed remote builds in B26245: Diff 25402!

Build is green

Patch application report for D7006 (id=25402)

Rebasing onto 34ff6c672a...

Current branch diff-target is up to date.
Changes applied before test
commit b53e1d7005d0c2e1e3b995dbee3fcee9bfa3a556
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jan 21 12:55:01 2022 +0100

    Stop using the deprecated 'TimestampWithTimezone.offset' attribute
    
    It will be replaced by what is currently called 'offset_bytes'

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/697/ for more details.

olasd added a subscriber: olasd.

Thanks!

This revision is now accepted and ready to land.Jan 21 2022, 2:47 PM