Page MenuHomeSoftware Heritage

Add test_origin_metadata, and fix a bug.
ClosedPublic

Authored by vlorentz on Dec 5 2018, 12:09 PM.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
test_origin_metadata
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2851
Build 3599: tox-on-jenkinsJenkins
Build 3598: arc lint + arc unit

Event Timeline

ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/loader/core/tests/test_loader.py
268

I'm unclear about that first call.
I know that in other diff, you comment alongside saying that it initializes the loader.
But i'm still unsure ;)

Other than that, sounds good.

This revision is now accepted and ready to land.Dec 5 2018, 2:28 PM
vlorentz added inline comments.
swh/loader/core/tests/test_loader.py
268

It sets self.origin_id and stuff. Nothing interesting.

This revision was automatically updated to reflect the committed changes.
swh/loader/core/tests/test_loader.py
268

ah yes, was wondering about that.
I just never connected the 2.

cool