Unfortunately, this file has no proper test, see T1393. I'm going to send a diff to swh.deposit that cover this, though.
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Branch
- tool_add
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2646 Build 3290: tox-on-jenkins Jenkins Build 3289: arc lint + arc unit
Event Timeline
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/24/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/24/console
Please explain why you need to consume the iterator in your commit message or as a comment in the code.
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/29/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/29/console
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/32/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/32/console
There should be at least an explanation about why this refactoring in the celery runner is required to add a test fixture, and give a clue what's going one in this refactoring.
Besides, you de facto change the API of the run_ready_tasks function so this must be documented in the doc string and the rationals for this API change should be explained in the commit message.