Page MenuHomeSoftware Heritage
Differential D718

Consume the iterator returned by tool_add.
ClosedPublic
Actions

Authored by vlorentz on Nov 27 2018, 6:35 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Test Plan

Unfortunately, this file has no proper test, see T1393. I'm going to send a diff to swh.deposit that cover this, though.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
tool_add
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2735
Build 3422: tox-on-jenkinsJenkins
Build 3421: arc lint + arc unit

Event Timeline

vlorentz created this revision.Nov 27 2018, 6:35 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 27 2018, 6:35 PM
swh-public-ci added a subscriber: swh-public-ci.Nov 27 2018, 6:37 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/24/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/24/console

Harbormaster failed remote builds in B2646: Diff 2272!Nov 27 2018, 6:37 PM
vlorentz added a child revision: D721: Remove Storage mock..Nov 27 2018, 6:51 PM
douardda requested changes to this revision.Nov 29 2018, 3:37 PM
douardda added a subscriber: douardda.

Please explain why you need to consume the iterator in your commit message or as a comment in the code.

This revision now requires changes to proceed.Nov 29 2018, 3:37 PM
vlorentz updated this revision to Diff 2333.Nov 30 2018, 10:13 AM
  • Explain in the commit message why list() is needed.
swh-public-ci added a comment.Nov 30 2018, 10:15 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/29/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/29/console

Harbormaster failed remote builds in B2710: Diff 2333!Nov 30 2018, 10:15 AM
douardda accepted this revision.Nov 30 2018, 12:03 PM
This revision is now accepted and ready to land.Nov 30 2018, 12:03 PM
vlorentz updated this revision to Diff 2355.Nov 30 2018, 12:22 PM
  • git magic
Harbormaster failed remote builds in B2735: Diff 2355!Nov 30 2018, 12:22 PM
vlorentz closed this revision.Nov 30 2018, 12:22 PM

landed

swh-public-ci added a comment.Nov 30 2018, 12:22 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/32/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/32/console

Revision Contents
Changeset List

PathSize
swh/
loader/
core/
2 lines

Diff 2355

View Options

swh/loader/core/loader.py

Loading...
About · Developer information · Legal