This adds 2 mixins:
- One to setup the loader data to ingest and check for the state after loading
- Another one to inhibit the self.storage calls from the loader-core implementation
Related T1238
Differential D467 Authored by ardumont on Oct 3 2018, 5:52 PM.
Details
Summary This adds 2 mixins:
Related T1238 Test Plan None for now (I focused on refactoring the modules depending on it). I
Diff Detail
Event TimelineThere are a very large number of changes, so older changes are hidden. Show Older Changes Herald added a reviewer: Reviewers. · View Herald TranscriptOct 3 2018, 5:52 PM2018-10-03 17:52:12 (UTC+2) Harbormaster completed remote builds in B1494: Diff 1430.Oct 3 2018, 5:52 PM2018-10-03 17:52:13 (UTC+2) ardumont edited the test plan for this revision. (Show Details)Oct 3 2018, 11:25 PM2018-10-03 23:25:31 (UTC+2) Comment Actions I like it, especially after seeing the number of lines removed in your other diffs. Some nitpicking in inline comments below.
ardumont added inline comments. ardumont marked 2 inline comments as done. Comment ActionsAdapt according review
Harbormaster completed remote builds in B1506: Diff 1444.Oct 4 2018, 11:39 AM2018-10-04 11:39:13 (UTC+2) Comment Actions
It's nice to drop code! Less to maintain \m/ Harbormaster completed remote builds in B1507: Diff 1445.Oct 4 2018, 11:53 AM2018-10-04 11:53:13 (UTC+2) Comment Actions Just a couple nitpicks but otherwise that's great and it will be really useful!
ardumont marked 3 inline comments as done. Comment Actions
Harbormaster completed remote builds in B1508: Diff 1446.Oct 4 2018, 12:14 PM2018-10-04 12:14:09 (UTC+2)
ardumont marked an inline comment as done. Comment Actions
Harbormaster completed remote builds in B1509: Diff 1447.Oct 4 2018, 12:28 PM2018-10-04 12:28:04 (UTC+2)
Comment Actions
Harbormaster completed remote builds in B1514: Diff 1453.Oct 4 2018, 3:22 PM2018-10-04 15:22:09 (UTC+2) ardumont added inline comments.
Harbormaster completed remote builds in B1557: Diff 1499.Oct 7 2018, 1:14 PM2018-10-07 13:14:39 (UTC+2) ardumont retitled this revision from loader.core: Add base loader core mixins to ease loader testing to loader.core.tests: Add loader core fixtures to ease loaders' tests.Oct 8 2018, 3:24 PM2018-10-08 15:24:37 (UTC+2) Comment Actions Rebase
Harbormaster completed remote builds in B1580: Diff 1542.Oct 8 2018, 3:24 PM2018-10-08 15:24:57 (UTC+2) Comment Actions besides the name mangling from hell, lgtm
This revision is now accepted and ready to land.Oct 8 2018, 3:54 PM2018-10-08 15:54:06 (UTC+2) ardumont added inline comments.
Harbormaster completed remote builds in B1582: Diff 1545.Oct 8 2018, 8:32 PM2018-10-08 20:32:23 (UTC+2) Harbormaster completed remote builds in B1584: Diff 1547.Oct 9 2018, 9:57 AM2018-10-09 09:57:43 (UTC+2) Harbormaster completed remote builds in B1585: Diff 1548.Oct 9 2018, 10:17 AM2018-10-09 10:17:33 (UTC+2) Harbormaster completed remote builds in B1586: Diff 1549.Oct 9 2018, 10:29 AM2018-10-09 10:29:17 (UTC+2) Comment Actions
Harbormaster completed remote builds in B1588: Diff 1551.Oct 9 2018, 10:52 AM2018-10-09 10:52:32 (UTC+2) Harbormaster completed remote builds in B1592: Diff 1555.Oct 9 2018, 12:22 PM2018-10-09 12:22:11 (UTC+2) Comment Actions
Harbormaster completed remote builds in B1594: Diff 1557.Oct 9 2018, 1:59 PM2018-10-09 13:59:27 (UTC+2) Closed by commit rDLDBASE43f7ba3cb6a3: README.md: Reference loader-pypi (authored by ardumont). · Explain WhyOct 9 2018, 1:59 PM2018-10-09 13:59:52 (UTC+2) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 1558 README.md
|