This adds 2 mixins:
- One to setup the loader data to ingest and check for the state after loading
- Another one to inhibit the self.storage calls from the loader-core implementation
Related T1238
Differential D467
loader.core.tests: Add loader core fixtures to ease loaders' tests ardumont on Oct 3 2018, 5:52 PM. Authored by
Details
This adds 2 mixins:
Related T1238 None for now (I focused on refactoring the modules depending on it). I
Diff Detail
Event TimelineThere are a very large number of changes, so older changes are hidden. Show Older Changes Comment Actions I like it, especially after seeing the number of lines removed in your other diffs. Some nitpicking in inline comments below.
Comment Actions Adapt according review
Comment Actions
It's nice to drop code! Less to maintain \m/ Comment Actions Just a couple nitpicks but otherwise that's great and it will be really useful!
Comment Actions
Comment Actions Rebase
Comment Actions besides the name mangling from hell, lgtm
Comment Actions
Comment Actions
|