Page MenuHomeSoftware Heritage

webapp: Be more lenient when browse lookup origin input is wrong (on optional parameters)
Closed, MigratedEdits Locked

Description

When browsing a revision, providing the wrong optional parameters, results in a 404 even though the main url is correct (without parameters).

Example:

https://archive.softwareheritage.org/browse/revision/a27a59f6b14c9fb13a6f998d8316628dafc1f60c/?origin_type=deposit&origin_url=https%3A//hal.inria.fr/hal-01727745

renders a 404 not found because the origin_url is wrong.

It should have been https://archive.softwareheritage.org/browse/revision/a27a59f6b14c9fb13a6f998d8316628dafc1f60c/?origin_type=deposit&origin_url=https%3A//hal.archives-ouvertes.fr/hal-01727745

Still, being more concilient in that kind of error would be more user-friendly.

Probably proposing something along the line of we did not find exactly that, maybe you meant that?

Event Timeline

ardumont triaged this task as Normal priority.Mar 21 2018, 2:57 PM
ardumont created this task.
ardumont updated the task description. (Show Details)
ardumont renamed this task from Improve browse lookup origin to webapp: Be more lenient when browse lookup origin input is wrong (on optional parameters).Mar 21 2018, 2:59 PM
ardumont added a subscriber: moranegg.
anlambert closed this task as Resolved.EditedMar 6 2019, 2:04 PM
anlambert claimed this task.
anlambert added a subscriber: anlambert.

I think we can consider that commit rDWAPPS5159dbd194a26a1c0dc8b04d9797f716b57e11ee addresses the issue reported in this task so closing it.