Page MenuHomeSoftware Heritage
Create Task
Maniphest T2557

"Save code now" history links lead to an error (because timestamp is null)
Closed, MigratedEdits Locked
Actions

Description

Steps:

  1. got to https://archive.softwareheritage.org/save/#requests
  2. click on the URL of any succeeded task
  3. it leads to an URL like: https://archive.softwareheritage.org/browse/origin/directory/?origin_url=https://github.com/MITDDC/zork.git&timestamp=null

which errors with BadInputExc: Unable to parse date string 'null'

If I'm reading Sentry correctly, it appears in v0.0.249

Sentry issue: SWH-WEBAPP-12X

Revisions and Commits

rDWAPPS Web applications
D3873rDWAPPSf8a6cf8f2470 assets/origin-save: Fix handling of null visit dates in requests list

Related Objects

Event Timeline

vlorentz triaged this task as High priority.Sep 2 2020, 10:44 PM
vlorentz created this task.
anlambert added a subscriber: anlambert.Sep 3 2020, 11:45 AM

Looks like that bug appeared yesterday according to the save requests list. I can not reproduce with docker so surely a side effect from another swh component, need to dig further on this.

anlambert added a comment.Sep 3 2020, 12:09 PM

Ok got it, there is currently a replication lag for the postgres database and recent origin visits have not yet been copied from belvedere to sommerset, so the null timestamp as the visit associated to a save request can not be found.

Nevertheless, the Web UI should not add the timestamp query parameter to browse URL if it is null. Diff incoming to fix that incorrect behavior.

anlambert added a revision: D3873: assets/origin-save: Fix handling of null visit dates in requests list.Sep 3 2020, 3:17 PM
olasd added subscribers: vsellier, ardumont, olasd.Sep 3 2020, 4:37 PM
In T2557#47920, @anlambert wrote:

Ok got it, there is currently a replication lag for the postgres database and recent origin visits have not yet been copied from belvedere to sommerset, so the null timestamp as the visit associated to a save request can not be found.

On that, and after chatting with @ardumont and @vsellier, I've submitted T2562

anlambert closed this task as Resolved by committing rDWAPPSf8a6cf8f2470: assets/origin-save: Fix handling of null visit dates in requests list.Sep 4 2020, 2:04 PM
anlambert claimed this task.
anlambert added a commit: rDWAPPSf8a6cf8f2470: assets/origin-save: Fix handling of null visit dates in requests list.
gitlab-migration changed the task status from Resolved to Migrated.Jan 8 2023, 4:31 PM
gitlab-migration claimed this task.
gitlab-migration added a subscriber: gitlab-migration.

This task has been migrated to GitLab.

About · Developer information · Legal