Page MenuHomeSoftware Heritage

assets/origin-save: Fix handling of null visit dates in requests list
ClosedPublic

Authored by anlambert on Thu, Sep 3, 3:17 PM.

Details

Summary

When a save request task succeeded but the corresponding visit is not yet available
in PostgreSQL database (replication lag), a null visit date can be returned so
handle that special case.

Closes T2557

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Thu, Sep 3, 3:17 PM

Build is green

Patch application report for D3873 (id=13667)

Rebasing onto 9c41d9f90f...

Current branch diff-target is up to date.
Changes applied before test
commit 49c914f4d88cc45aeb1ae6f83717d37596ca0155
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Sep 3 15:11:50 2020 +0200

    assets/origin-save: Fix handling of null visit dates in requests list
    
    Summary:
    
    When a save request task succeeded but the corresponding visit is not yet available
    in PostgreSQL database (replication lag), a null visit date can be returned so
    handle that special case.
    
    Closes T2557
    
    Test Plan:
    
    Reviewers:
    
    Subscribers:

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/351/ for more details.

ardumont accepted this revision.Thu, Sep 3, 6:01 PM
This revision is now accepted and ready to land.Thu, Sep 3, 6:01 PM