Page MenuHomeSoftware Heritage

tests: Refactor repository with svn:externals property scenario
ClosedPublic

Authored by ardumont on Jul 3 2020, 11:29 AM.

Details

Summary

Related to T2462

That's what @anlambert was talking about during our weekly planning ;)

Test Plan

tox

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 3 2020, 11:29 AM

Build is green

Patch application report for D3405 (id=12078)

Could not rebase; Attempt merge onto 62973d8447...

Updating 62973d8..da93e37
Fast-forward
 swh/loader/svn/tests/test_loader.py | 140 ++++++++++++++----------------------
 1 file changed, 55 insertions(+), 85 deletions(-)
Changes applied before test
commit da93e37b92a8038c0ea301fc67a7ddcf5823b97a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 11:28:36 2020 +0200

    tests: Refactor repository with svn:externals property scenario
    
    Related to T2462

commit 6636006a6fda54dde5dd5d28255ca0628f8fdc73
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 11:17:00 2020 +0200

    tests: Refactor mixed crlf lf scenario
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/55/ for more details.

Looks good.

We should really stop throwing an exception when encountering a svn:externals property as numerous svn repos use it
and the need for subversion repository archival is growing (Inria gforge for instance).

How about brainstorming again on T611 next week the day we meet @rdicosmo at the office ?

anlambert accepted this revision.Jul 3 2020, 1:23 PM
This revision is now accepted and ready to land.Jul 3 2020, 1:23 PM

Looks good.

We should really stop throwing an exception when encountering a svn:externals property as numerous svn repos use it
and the need for subversion repository archival is growing (Inria gforge for instance).

How about brainstorming again on T611 next week the day we meet @rdicosmo at the office ?

sure. I'll need to refresh myself on T611 though ;)